Re: [PATCH] Add r-scran 1.2.0 and all its dependencies

[Ricardo Wurmus]

Ra <address@hidden> writes:

> Hi Ricardo,
> there was an issue with the r-shiny patch, the license was wrong. So this
> is the new set of patches.

Thank you.  I updated and pushed all patches up to r-shiny.  The changes
are:

* Changed the descriptions, so that they are made up of full sentences.
* Added a proper commit message.

Please take a look at those changes for future reference.

I didn’t push r-shiny, because it contains a lot of minified Javascript
files without corresponding source files.

Here is an edited list:

  shiny/inst/www/shared/babel-polyfill.min.js
  shiny/inst/www/shared/highlight/highlight.pack.js
  shiny/inst/www/shared/json2-min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.nb.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.th.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.pt.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.az.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.en-AU.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.ms.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.id.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.me.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.hr.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.bs.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.lv.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.ka.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.ja.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.sk.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.nl.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.is.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.fr.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.mk.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.fr-CH.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.sq.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.pt-BR.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.vi.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.ru.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.fo.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.ko.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.it-CH.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.cs.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.ca.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.mn.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.kk.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.fa.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.nl-BE.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.sl.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.zh-CN.min.js
  
shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.rs-latin.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.tr.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.zh-TW.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.cy.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.pl.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.lt.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.el.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.no.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.da.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.gl.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.uk.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.eu.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.hy.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.ro.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.et.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.kh.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.eo.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.he.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.it.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.es.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.bg.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.ar.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.sw.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.sv.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.rs.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.en-GB.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.kr.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.de.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.fi.min.js
  
shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.sr-latin.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.sr.min.js
  shiny/inst/www/shared/datepicker/js/locales/bootstrap-datepicker.hu.min.js
  shiny/inst/www/shared/bootstrap/shim/respond.min.js
  shiny/inst/www/shared/bootstrap/shim/html5shiv.min.js
  shiny/inst/www/shared/selectize/js/es5-shim.min.js
  shiny/inst/www/shared/selectize/js/selectize.min.js
  shiny/inst/www/shared/datatables/js/jquery.dataTables.min.js
  shiny/inst/www/shared/strftime/strftime-min.js
  shiny/inst/www/shared/ionrangeslider/js/ion.rangeSlider.min.js

I removed those Javascript files from the list that seem to have
matching source files (so we’d only need to minify them in a build
phase).

We cannot accept the patch for r-shiny when it contains these minified
JavaScript files, as they are not source code.  Unfortunately, replacing
them won’t be easy, because things like babel-polyfill require an npm
build system.

If you want to use the r-shiny package you can add it to a module file
in a directory that’s listed on your GUIX_PACKAGE_PATH.  That’s how
we’re using r-shiny at my institute as well.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net