guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: arc-theme: Update to 20161119


From: Leo Famulari
Subject: Re: [PATCH] gnu: arc-theme: Update to 20161119
Date: Mon, 2 Jan 2017 12:10:43 -0500
User-agent: Mutt/1.7.2 (2016-11-26)

On Mon, Jan 02, 2017 at 07:51:10AM +0000, Brandon Ludwig wrote:
> Hello,
> 
> 
> this patch updates arc-theme to 20161119.

>From 3e694bb4e38e6380a2113cb7bc656b85be2aa511 Mon Sep 17 00:00:00 2001
From: bldtg <address@hidden>
Date: Sun, 1 Jan 2017 21:30:41 -0900
Subject: [PATCH] gnu: arc-theme: Update to 20161119

Thanks!

Can you clarify which name you want to appear in the Git log? 'bldtg',
'Brandon Ludwig', something else? You can use whatever you want.

Also, the commit message should include a description of the changes at
the "file-level". In this case, that looks like this:

* gnu/packages/gnome.scm (arc-theme): Update to 20161119.

This is what is meant when the manual mentions the GNU ChangeLog format:

https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

I usually look at earlier commits for examples when I'm unsure.

Normally I'd add that line for you when pushing, but since I'm asking
for clarification about which name to use, I figure you can amend the
commit to include this part :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]