[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: doxygen: Use sh from the store.
From: |
Danny Milosavljevic |
Subject: |
Re: [PATCH] gnu: doxygen: Use sh from the store. |
Date: |
Tue, 3 Jan 2017 13:28:37 +0100 |
Thanks for the patch! Looks good to me.
In any case, if we search for "portable_system", we find that there are lots of
other things that don't use in-store names:
./cite.cpp: if ((exitCode=portable_system("perl","\""+bib2xhtmlFile+"\"
"+bibOutputFiles+" \""+
./dia.cpp: if ((exitCode=portable_system(diaExe,diaArgs,FALSE))!=0) // from
config
./dia.cpp: if (portable_system("epstopdf",epstopdfArgs)!=0)
./diagram.cpp: if (portable_system("epstopdf",epstopdfArgs)!=0)
./docparser.cpp: if (portable_system("epstopdf",epstopdfArgs)!=0)
./dot.cpp: if ((exitCode=portable_system(m_dotExe.data(),dotArgs,FALSE))!=0)
// from config
./dot.cpp: if
((exitCode=portable_system(m_dotExe.data(),dotArgs,FALSE))!=0) // from config
./dot.cpp: if (!m_postCmd.isEmpty() &&
portable_system(m_postCmd.data(),m_postArgs.data())!=0) // seems to be not set
anywhere
./doxygen.cpp: if (portable_system(Config_getString("HHC_LOCATION"),
"index.hhp", Debug::isFlagSet(Debug::ExtCmd))) // from config
./doxygen.cpp: if (portable_system(Config_getString("QHG_LOCATION"),
args.data(), FALSE)) // from config
./formula.cpp: if (portable_system(latexCmd,"_formulas.tex")!=0) // from
config
./formula.cpp: if (portable_system("dvips",dviArgs)!=0)
./formula.cpp: if
(portable_system(portable_ghostScriptCommand(),gsArgs)!=0) //
portable_ghostScriptCommand body hardcodes executable name
./htags.cpp: bool result=portable_system("htags",commandLine,FALSE)==0;
./msc.cpp: if ((exitCode=portable_system(mscExe,mscArgs,FALSE))!=0) // from
config
./msc.cpp: if (portable_system("epstopdf",epstopdfArgs)!=0)
./msc.cpp: if ((exitCode=portable_system(mscExe,mscArgs,FALSE))!=0) // from
config
./plantuml.cpp: if ((exitCode=portable_system(pumlExe,pumlArgs,TRUE))!=0) //
java, hardcoded
./plantuml.cpp: if ((exitCode=portable_system("epstopdf",epstopdfArgs))!=0)
./portable.cpp:int portable_system(const char *command,const char *args,bool
commandHasConsole) // should have argument list, not huge string
./portable.h:int portable_system(const char *command,const char
*args,bool commandHasConsole=TRUE);
./vhdldocgen.cpp: if (portable_system("dot",vlargs)!=0)
./vhdldocgen.cpp: if (portable_system("dot",vlargs)!=0)
Aaaah found sprintf without max length specifier.
Dear god is doxygen unsafe. I should refrain from reading the source code of
some popular packages - it doesn't end well.
If someone is motivated, could also fix the above executable names later.