[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add beep.
From: |
Tobias Geerinckx-Rice |
Subject: |
Re: [PATCH] gnu: Add beep. |
Date: |
Thu, 5 Jan 2017 13:18:05 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
José,
On 04/01/17 23:32, José Miguel Sánchez García wrote:
> I've applied your changes, ran guix lint and tested it. Here you have
> the fixed patch.
Thank you!
Pushed as abe2ec7 with small adjustments below.
I hope that's all right.
Kind regards,
T G-R
---
Fix indentation:
(base32
- "0bgch6jq5cahakk3kbr9549iysf2dik09afixxy5brbxk1xfzb2r"))))
+ "0bgch6jq5cahakk3kbr9549iysf2dik09afixxy5brbxk1xfzb2r"))))
Use lambda* instead of %outputs directly, don't abbreviate phase names,
(partially) restore use of let:
- (lambda _
- (substitute* "Makefile" (("/usr") (assoc-ref %outputs "out")))))
- (add-before 'install 'create-dest-dirs
- (lambda _
- (mkdir-p (string-append (assoc-ref %outputs "out") "/bin"))
- (mkdir-p (string-append (assoc-ref %outputs "out") "/man/man1")))))))
+ (lambda* (#:key outputs #:allow-other-keys)
+ (substitute* "Makefile" (("/usr") (assoc-ref outputs "out")))))
+ (add-before 'install 'create-output-directories
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref %outputs "out")))
+ (mkdir-p (string-append out "/bin"))
+ (mkdir-p (string-append out "/man/man1"))))))))
Fix typo:
- (synopsis "Linux command-line utilitu to control the PC speaker")
+ (synopsis "Linux command-line utility to control the PC speaker")
signature.asc
Description: OpenPGP digital signature