[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] gnu: libtool: Use 'modify-phases'.
|
From: |
Leo Famulari |
|
Subject: |
Re: [PATCH 1/2] gnu: libtool: Use 'modify-phases'. |
|
Date: |
Thu, 5 Jan 2017 10:43:48 -0500 |
|
User-agent: |
Mutt/1.7.2 (2016-11-26) |
On Thu, Jan 05, 2017 at 11:36:55AM +0100, Ludovic Courtès wrote:
> Leo Famulari <address@hidden> skribis:
> > On Sun, Jan 01, 2017 at 03:24:27PM +0000, ng0 wrote:
> > + (modify-phases %standard-phases
> > + (add-before 'check 'pre-check
> > + (lambda* (#:key inputs #:allow-other-keys)
>
> Could you align “(” below the ‘d’ of ‘add-before’?
Done.
> > + (add-after 'patch-source-shebangs 'restore-ltmain-shebang
> > + (lambda* (#:key inputs #:allow-other-keys)
>
> Likewise.
Done.
> > + (substitute* "build-aux/ltmain.in"
> > + (((string-append (assoc-ref inputs "bash")
> > "/bin/sh"))
> > + "/bin/sh")))))))
>
> We should use literal strings for patterns, like:
>
> (substitute* …
> (("^#!.*/bin/sh$") …))
Done.
> > From 809120b991603b8c557be7481be2bbae29bd8a7f Mon Sep 17 00:00:00 2001
> > From: Leo Famulari <address@hidden>
> > Date: Wed, 4 Jan 2017 19:44:27 -0500
> > Subject: [PATCH 3/3] gnu: libtool: Don't replace 'sh' reference with 'bash'.
> >
> > Bash behaves differently based on how it is invoked (see Invocation in
> > bash(1)).
> >
> > * gnu/packages/autotools.scm (libtool)[arguments]: Use /bin/sh instead
> > of /bin/bash in 'pre-check' phase. Fix typo in comment.
>
> Makes sense.
More are coming!
> Could you push them to ‘core-updates’?
Done!
> Thank you Leo & ng0!
Thanks ng0!
signature.asc
Description: PGP signature