guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add nim.


From: José Miguel Sánchez García
Subject: Re: [PATCH] gnu: Add nim.
Date: Mon, 09 Jan 2017 18:21:26 +0100
User-agent: Roundcube Webmail/1.0.6

On 2017-01-09 18:09, David Craven wrote:
Hi Jose,

Some changes I made:

* change module name to (gnu packages nim).
* reorder imports alphabetically.
* added you to the copyright header.
* added a comment as to why the tests are disabled.
* returned true after substitute*
* used (zero? (system* "./install.sh" ...
* removed new line after description
* added a trailing dot to the commit message headline

I don't think we need a separate /opt subfolder, opt is basically
/gnu/store for FHS systems.

Pushed as 84aafbbb664925ed1a9de3e53238bc54c743a968. Thank you!
--------------------------------------------------------------------------------
Thanks for cleaning *the stupid mess* I made with this particular package. Sorry for that, I'll start to calm down and check my patches before submitting.

--
José Miguel Sánchez García



reply via email to

[Prev in Thread] Current Thread [Next in Thread]