guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] file-systems: Refactor check-file-system.


From: Ludovic Courtès
Subject: Re: [PATCH 1/4] file-systems: Refactor check-file-system.
Date: Tue, 10 Jan 2017 00:11:02 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Hi!

David Craven <address@hidden> skribis:

> * gnu/build/file-systems.scm (check-file-system): Use file-system type
>   specific checker.
>   (check-ext2-file-system): New variable.

[...]

> +(define (check-ext2-file-system device)
> +  "Return the health of an ext2 file system on DEVICE."
> +  (match (status:exit-val
> +          (system* "e2fsck" "-v" "-p" "-C" "0" device))

[...]

> -  (define fsck
> -    (string-append "fsck." type))

What’s wrong with using “fsck.extN” like we did before?
(Either way is fine with me, just curious.)

Otherwise LGTM, thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]