[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add ldc-1.1.0-beta6
From: |
Frederick Muriithi |
Subject: |
Re: [PATCH] gnu: Add ldc-1.1.0-beta6 |
Date: |
Tue, 10 Jan 2017 08:55:59 +0300 |
On Mon, Jan 9, 2017 at 5:41 PM, Ludovic Courtès <address@hidden> wrote:
> Hello!
>
> Sorry for the late reply!
>
> ...
>
> One question: We usually avoid packaging software that has no release or
> has an “alpha” or “beta” label. Do you think we could wait for 1.1.0 to
> be officially released? Or are there good reasons why we should not
> wait?
>
I chose to write the patch, since there is need for the newer versions
of ldc to compile some tools like sambamba
(http://lomereiter.github.io/sambamba/) successfully. These tools are
needed, but will not compile with the older stable version (0.17.2).
Since both versions, the stable version and one of the beta versions,
might be needed, I thought to write a definition for it, to get it on
guix and make it easier to provide the tools for the scientists on the
bleeding edge.
>
> ...
>
> Could you add a comment explaining why the previous version of these is
> needed, instead of the current version?
>
> ...
>
> Could you add a line or two explaining at the top of patch explaining
> what it does and why, and what its upstream status is?
>
> For example, I think this one disables a test that would require GDB,
> which is not an input (?), and presumably it won’t be submitted
> upstream.
>
> ...
>
> I think it’s better to just delete the two lines instead of commenting
> them out: that makes the patch easier to read.
>
> Hope this makes sense.
>
> Thanks for your contribution!
>
> Ludo’.
Thanks for the feedback. I will work on these and send an updated patch.
--
Frederick M. Muriithi
- [PATCH] gnu: Add ldc-1.1.0-beta6, Frederick Muriithi, 2017/01/06
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Pjotr Prins, 2017/01/07
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Ludovic Courtès, 2017/01/09
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6,
Frederick Muriithi <=
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Frederick Muriithi, 2017/01/10
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Ludovic Courtès, 2017/01/12
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Frederick Muriithi, 2017/01/17
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Ludovic Courtès, 2017/01/19
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Frederick Muriithi, 2017/01/19
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Ludovic Courtès, 2017/01/20
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Frederick Muriithi, 2017/01/22
- Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Ludovic Courtès, 2017/01/27
Re: [PATCH] gnu: Add ldc-1.1.0-beta6, Pjotr Prins, 2017/01/19