Re: Introduce packages/chess.el

[Stefan Reichör]

Hi again!

Does someone provide feedback for this patch?
Is it useful or is increasing the number of .scm files a bad thing?

Thanks,
  Stefan.

> Hi there,
>
> I would like to add some chess related packages to GUIX.
> I found the packages xboard and chess that are already covered by GUIX.
>
> The attached patch moves these two packages to a new file named chess.scm
>
> I would like to add some more chess related packages to chess.scm in the 
> future.
>
> Stefan.
>
>
> From 7fb3eba51f0919a2e1c9b13ecb4ff77757bf4267 Mon Sep 17 00:00:00 2001
> From: Stefan Reichoer <address@hidden>
> Date: Sat, 7 Jan 2017 20:30:14 +0100
> Subject: [PATCH] gnu: chess, xboard: Move to (gnu packages chess).
>
> * gnu/packages/games.scm: Move 'chess', 'xboard' to...
>
> * gnu/packages/chess.scm: New file.
>
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add chess.scm.
> ---
>  gnu/local.mk           |  1 +
>  gnu/packages/chess.scm | 77 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  gnu/packages/games.scm | 49 --------------------------------
>  3 files changed, 78 insertions(+), 49 deletions(-)
>  create mode 100644 gnu/packages/chess.scm
>
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 1889a0e..b043f41 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -69,6 +69,7 @@ GNU_SYSTEM_MODULES =                                \
>    %D%/packages/c.scm                         \
>    %D%/packages/calcurse.scm                  \
>    %D%/packages/ccache.scm                    \
> +  %D%/packages/chess.scm                     \
>    %D%/packages/cdrom.scm                     \
>    %D%/packages/certs.scm                     \
>    %D%/packages/check.scm                     \
> diff --git a/gnu/packages/chess.scm b/gnu/packages/chess.scm
> new file mode 100644
> index 0000000..28383c8
> --- /dev/null
> +++ b/gnu/packages/chess.scm
> @@ -0,0 +1,77 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2013 John Darrington <address@hidden>
> +;;; Copyright © 2016 Sou Bunnbu <address@hidden>
> +;;; Copyright © 2016 Efraim Flashner <address@hidden>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages chess)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (gnu packages)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages texinfo)
> +  #:use-module (guix build-system gnu))
> +
> +(define-public chess
> +  (package
> +    (name "chess")
> +    (version "6.2.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://gnu/chess/gnuchess-" version
> +                           ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1vw2w3jwnmn44d5vsw47f8y70xvxcsz9m5msq9fgqlzjch15qhiw"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://www.gnu.org/software/chess";)
> +    (synopsis "Full chess implementation")
> +    (description "GNU Chess is a chess engine.  It allows you to compete
> +against the computer in a game of chess, either through the default terminal
> +interface or via an external visual interface such as GNU XBoard.")
> +    (license license:gpl3+)))
> +
> +(define-public xboard
> +  (package
> +    (name "xboard")
> +    (version "4.9.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://gnu/xboard/xboard-" version
> +                           ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1mkh36xnnacnz9r00b5f9ld9309k32jv6mcavklbdnca8bl56bib"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("gtk+" ,gtk+-2)
> +       ("librsvg" ,librsvg)))
> +    (native-inputs
> +     `(("texinfo" ,texinfo)
> +       ("pkg-config" ,pkg-config)))
> +    (home-page "https://www.gnu.org/software/xboard";)
> +    (synopsis "Graphical user interface for chess programs")
> +    (description "GNU XBoard is a graphical board for all varieties of chess,
> +including international chess, xiangqi (Chinese chess), shogi (Japanese 
> chess)
> +and Makruk.  Several lesser-known variants are also supported.  It presents a
> +fully interactive graphical interface and it can load and save games in the
> +Portable Game Notation.")
> +    (license license:gpl3+)))
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index c449f59..2b260ca 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -327,26 +327,6 @@ settings up to 132x300 and can scroll lines all at the 
> same rate or
>  asynchronously and at a user-defined speed.")
>      (license license:gpl2+)))
>  
> -(define-public chess
> -  (package
> -    (name "chess")
> -    (version "6.2.4")
> -    (source
> -     (origin
> -       (method url-fetch)
> -       (uri (string-append "mirror://gnu/chess/gnuchess-" version
> -                           ".tar.gz"))
> -       (sha256
> -        (base32
> -         "1vw2w3jwnmn44d5vsw47f8y70xvxcsz9m5msq9fgqlzjch15qhiw"))))
> -    (build-system gnu-build-system)
> -    (home-page "https://www.gnu.org/software/chess";)
> -    (synopsis "Full chess implementation")
> -    (description "GNU Chess is a chess engine.  It allows you to compete
> -against the computer in a game of chess, either through the default terminal
> -interface or via an external visual interface such as GNU XBoard.")
> -    (license license:gpl3+)))
> -
>  (define freedink-engine
>    (package
>      (name "freedink-engine")
> @@ -428,35 +408,6 @@ exec ~a/bin/freedink -refdir ~a/share/dink\n"
>                ("bash" ,bash)))
>      (native-inputs '())))
>  
> -(define-public xboard
> -  (package
> -    (name "xboard")
> -    (version "4.9.1")
> -    (source
> -     (origin
> -       (method url-fetch)
> -       (uri (string-append "mirror://gnu/xboard/xboard-" version
> -                           ".tar.gz"))
> -       (sha256
> -        (base32
> -         "1mkh36xnnacnz9r00b5f9ld9309k32jv6mcavklbdnca8bl56bib"))))
> -    (build-system gnu-build-system)
> -    (inputs
> -     `(("gtk+" ,gtk+-2)
> -       ("librsvg" ,librsvg)))
> -    (native-inputs
> -     `(("texinfo" ,texinfo)
> -       ("pkg-config" ,pkg-config)))
> -    (home-page "https://www.gnu.org/software/xboard";)
> -    (synopsis "Graphical user interface for chess programs")
> -    (description "GNU XBoard is a graphical board for all varieties of chess,
> -including international chess, xiangqi (Chinese chess), shogi (Japanese 
> chess)
> -and Makruk.  Several lesser-known variants are also supported.  It presents a
> -fully interactive graphical interface and it can load and save games in the
> -Portable Game Notation.")
> -    (license license:gpl3+)))
> -
> -
>  (define-public xboing
>    (package
>      (name "xboing")