guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: services: Add redis-service


From: Thompson, David
Subject: Re: [PATCH] gnu: services: Add redis-service
Date: Fri, 13 Jan 2017 09:22:01 -0500

Hello,

On Tue, Jan 10, 2017 at 2:24 AM, Christopher Baines <address@hidden> wrote:
>
> diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm
> index d88c839f7..b6bdd6080 100644
> --- a/gnu/services/databases.scm
> +++ b/gnu/services/databases.scm
> @@ -35,7 +35,11 @@
>              mysql-service
>              mysql-service-type
>              mysql-configuration
> -            mysql-configuration?))
> +            mysql-configuration?
> +
> +            redis-configuration
> +            redis-configuration?
> +            redis-service-type))
>
>  ;;; Commentary:
>  ;;;
> @@ -287,3 +291,78 @@ database server.
>  The optional @var{config} argument specifies the configuration for
>  @command{mysqld}, which should be a @code{<mysql-configuration>} object."
>    (service mysql-service-type config))
> +
> +
> +;;;
> +;;; Redis
> +;;;
> +
> +(define-record-type* <redis-configuration>
> +  redis-configuration make-redis-configuration
> +  redis-configuration?
> +  (redis             redis-configuration-redis ;<package>
> +                     (default redis))
> +  (bind              redis-configuration-bind
> +                     (default "127.0.0.1"))
> +  (port              redis-configuration-port
> +                     (default 6379))
> +  (working-directory redis-configuration-working-directory
> +                     (default "/var/lib/redis"))
> +  (config-file       redis-configuration-config-file
> +                     (default #f)))

I'm seeing a trend where people write services with configuration
types that don't cover nearly the amount of configuration options to
make the service useful.  MySQL, and now this Redis server, are
examples of this.  There are many more configuration options in Redis
than this service exposes.

What do we do?

- Dave



reply via email to

[Prev in Thread] Current Thread [Next in Thread]