[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] gnu: Add scrypt.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH 1/1] gnu: Add scrypt. |
|
Date: |
Mon, 16 Jan 2017 14:39:49 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Leo Famulari <address@hidden> skribis:
> On Mon, Jan 16, 2017 at 12:43:14AM -0500, Leo Famulari wrote:
>> * gnu/packages/crypto.scm (scrypt): New variable.
>
>> + (arguments
>> + `(#:phases (modify-phases %standard-phases
>> + (add-after 'unpack 'patch-command-invocations
>
> I realized this indentation is too far to the right.
>
>> + (synopsis "Memory-hard key derivation function")
>
> And the synopsis should probably be something like "Memory-hard
> encryption tool". At least, it should include "encryption tool".
Agreed.
Also:
> + (add-after 'unpack 'patch-command-invocations
> + (lambda _
> + (substitute* '("Makefile.in" "autocrap/Makefile.am")
> + (("command -p") ""))
> + #t))
It’s probably enough to patch Makefile.in, and it avoids triggering an
‘automake’ invocation due to Makefile.am being more recent.
The rest LGTM, thanks!
Ludo’.