guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add guildhall.


From: Ricardo Wurmus
Subject: Re: [PATCH] gnu: Add guildhall.
Date: Mon, 16 Jan 2017 23:50:40 +0100
User-agent: mu4e 0.9.18; emacs 25.1.1

Ludovic Courtès <address@hidden> writes:

> Ricardo Wurmus <address@hidden> skribis:
>
>> * gnu/packages/guile.scm (guildhall): New variable.
>
> [...]
>
>> +       `(;; FIXME: tests fail for unknown reason.  They seem to try to load
>> +         ;; the bash executable as a Scheme file.  See bug report at
>> +         ;; https://github.com/ijp/guildhall/issues/22
>> +         #:tests? #f
>
> I think that’s because Makefile.am has:
>
>   TESTS_ENVIRONMENT = $(GUILE) …
>
> whereas it should instead do (assuming test files have the .scm
> extension):
>
>   SCM_LOG_DRIVER = $(GUILE) …
>
> and have ‘TESTS_ENVIRONMENT’ contain only environment variables.
>
> See
> <http://git.savannah.gnu.org/cgit/skribilo.git/commit/?id=d3a740cca088e6ec981e4b80a10f53fcfe094511>
> for an example of the modification that is needed.

Interesting.  Do you want me to patch this in our package or should I
just forward this info to upstream and have them fix it?  (There’s an
open uncommented bug report about this.)

> Also, maybe add a ‘package-for-guile-2.2’ variant if that works (which
> seems unlikely…).

Okay.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net




reply via email to

[Prev in Thread] Current Thread [Next in Thread]