[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/16] gnu: Add hisat2.
|
From: |
Ricardo Wurmus |
|
Subject: |
Re: [PATCH 02/16] gnu: Add hisat2. |
|
Date: |
Tue, 17 Jan 2017 21:49:20 +0100 |
|
User-agent: |
mu4e 0.9.18; emacs 25.1.1 |
Leo Famulari <address@hidden> writes:
> On Tue, Jan 17, 2017 at 03:11:27PM +0100, Ricardo Wurmus wrote:
>> * gnu/packages/bioinformatics.scm (hisat2): New variable.
>
>> + #:make-flags (list "CC=gcc" "CXX=g++" "allall")
>
> "allall"... We can categorize this alongside -Weverything! ;)
>
>> + (add-after 'unpack 'make-deterministic
>> + (lambda _
>> + (substitute* "Makefile"
>> + (("`date`") "0"))
>
> I'd take the value of SOURCE_DATE_EPOCH from the environment, but it's
> not very important.
Oh, I’m sorry. I have just pushed based on Marius’s review and didn’t
see your message in time. I’ll keep SOURCE_DATE_EPOCH in mind for
future cases.
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
- [PATCH 00/16] Bioinfo stuff, Ricardo Wurmus, 2017/01/17
- [PATCH 03/16] gnu: Add ribodiff., Ricardo Wurmus, 2017/01/17
- [PATCH 02/16] gnu: Add hisat2., Ricardo Wurmus, 2017/01/17
- [PATCH 04/16] gnu: Add r-compquadform., Ricardo Wurmus, 2017/01/17
- [PATCH 05/16] gnu: Add r-seqminer., Ricardo Wurmus, 2017/01/17
- [PATCH 07/16] gnu: Add r-maldiquant., Ricardo Wurmus, 2017/01/17
- [PATCH 06/16] gnu: Add r-raremetals2., Ricardo Wurmus, 2017/01/17
[PATCH 08/16] gnu: Add r-protgenerics., Ricardo Wurmus, 2017/01/17
[PATCH 09/16] gnu: Add r-mzr., Ricardo Wurmus, 2017/01/17
[PATCH 10/16] gnu: Add r-affyio., Ricardo Wurmus, 2017/01/17