[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] gnu: icestorm: Replace reference in icebox_vlog.
|
From: |
Leo Famulari |
|
Subject: |
Re: [PATCH 1/1] gnu: icestorm: Replace reference in icebox_vlog. |
|
Date: |
Tue, 17 Jan 2017 15:53:57 -0500 |
|
User-agent: |
Mutt/1.7.2 (2016-11-26) |
On Mon, Jan 16, 2017 at 03:21:29PM +0100, Danny Milosavljevic wrote:
> Hi,
>
> > I should have probably added a different phase for the
> > "icebox/icebox_vlog.py" substitution, to make clear it's the only path
> > which is a run-time reference. The installed icebox_vlog, can't find the
> > chipdb.txt file, if we don't make the substitution.
>
> Yeah, I think how you did it now is best.
>
> LGTM!
>
> I've built it and it works.
>
> I'll leave some time for others to comment. Afterwards, I'll commit it
> to master (since it'll cause rebuild of one icestorm-dependent
> package).
LGTM! Thanks Theodoros and Danny!