Re: [PATCH 5/8] gnu: Add python-geventhttpclient.

[Marius Bakke]

Danny Milosavljevic <address@hidden> writes:

> * gnu/packages/python.scm (python-geventhttpclient, python2-geventhttpclient):
>   New variables.
> ---
>  gnu/packages/python.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index deb801631..8c81eae64 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -12656,6 +12656,29 @@ Features:
>  @end enumerate")
>      (license (license:x11-style "file://LICENSE"))))
>  
> +(define-public python-geventhttpclient
> +  (package
> +    (name "python-geventhttpclient")
> +    (version "1.3.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "geventhttpclient" version))
> +        (sha256
> +          (base32 "07d0q3wzmml75227r6y6mrl5a0zpf4v9gj0ni5rhbyzmaj4az1xx"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-gevent" ,python-gevent)
> +       ("python-six" ,python-six)
> +       ("python-certifi" ,python-certifi)))
> +    (home-page "http://github.com/gwik/geventhttpclient";)
> +    (synopsis "HTTP client library for gevent")
> +    (description "This package provides an HTTP client library for gevent in 
> Python.")
> +    (license license:expat)))
> +
> +(define-public python2-geventhttpclient
> +  (package-with-python2 python-geventhttpclient))

'python setup.py test' doesn't actually do anything on this package. In
addition, the tarball comes with .pyc files for the tests and breaks.

Here is a patch with .pyc files removed and tests enabled:

signature.asc
Description: PGP signature

>From b991e2e4981bf8c05bf524f6eb87d47adebc2090 Mon Sep 17 00:00:00 2001
From: Marius Bakke <address@hidden>
Date: Tue, 17 Jan 2017 23:13:19 +0100
Subject: [PATCH] gnu: Add python-geventhttpclient.

* gnu/packages/python.scm (python-geventhttpclient, python2-geventhttpclient):
New variables.
---
 gnu/packages/python.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index a3a3c6c45..afbb3a367 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -10515,6 +10515,51 @@ to provide a high-level synchronous API on top of the 
libev event loop.")
 (define-public python2-gevent
   (package-with-python2 python-gevent))
 
+(define-public python-geventhttpclient
+  (package
+    (name "python-geventhttpclient")
+    (version "1.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "geventhttpclient" version))
+              (sha256
+               (base32
+                "07d0q3wzmml75227r6y6mrl5a0zpf4v9gj0ni5rhbyzmaj4az1xx"))
+              (modules '((guix build utils)))
+              (snippet
+               '(begin
+                  ;; Delete pre-compiled files.
+                  (for-each delete-file (find-files "src/geventhttpclient"
+                                                    ".*\\.pyc"))
+                  #t))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'delete-network-tests
+           (lambda _
+             (delete-file "src/geventhttpclient/tests/test_client.py")
+             #t))
+         (delete 'check)
+         (add-after 'install 'check
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (add-installed-pythonpath inputs outputs)
+             (zero? (system* "py.test" "src/geventhttpclient/tests" "-v")))))))
+    (native-inputs
+     `(("python-pytest" ,python-pytest)))
+    (propagated-inputs
+     `(("python-certifi" ,python-certifi)
+       ("python-gevent" ,python-gevent)
+       ("python-six" ,python-six)))
+    (home-page "http://github.com/gwik/geventhttpclient";)
+    (synopsis "HTTP client library for gevent")
+    (description "@code{python-geventhttpclient} is a high performance,
+concurrent HTTP client library for python using @code{gevent}.")
+    (license license:expat)))
+
+(define-public python2-geventhttpclient
+  (package-with-python2 python-geventhttpclient))
+
 (define-public python-twisted
   (package
     (name "python-twisted")
-- 
2.11.0