Re: [PATCH] gnu: Add guildhall.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> Ricardo Wurmus <address@hidden> skribis:
>>
>>> * gnu/packages/guile.scm (guildhall): New variable.
>>
>> [...]
>>
>>> +       `(;; FIXME: tests fail for unknown reason.  They seem to try to load
>>> +         ;; the bash executable as a Scheme file.  See bug report at
>>> +         ;; https://github.com/ijp/guildhall/issues/22
>>> +         #:tests? #f
>>
>> I think that’s because Makefile.am has:
>>
>>   TESTS_ENVIRONMENT = $(GUILE) …
>>
>> whereas it should instead do (assuming test files have the .scm
>> extension):
>>
>>   SCM_LOG_DRIVER = $(GUILE) …
>>
>> and have ‘TESTS_ENVIRONMENT’ contain only environment variables.
>>
>> See
>> <http://git.savannah.gnu.org/cgit/skribilo.git/commit/?id=d3a740cca088e6ec981e4b80a10f53fcfe094511>
>> for an example of the modification that is needed.
>
> Interesting.  Do you want me to patch this in our package or should I
> just forward this info to upstream and have them fix it?  (There’s an
> open uncommented bug report about this.)

You could do both, but at least report it upstream since it’s easily
fixed.

TIA!
Ludo’.