guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 8/8] gnu: python-dulwich: Fix tests.


From: Danny Milosavljevic
Subject: Re: [PATCH 8/8] gnu: python-dulwich: Fix tests.
Date: Tue, 17 Jan 2017 23:58:40 +0100

Hi,

On Tue, 17 Jan 2017 23:55:50 +0100
Marius Bakke <address@hidden> wrote:
> > +             (setenv "TEST_RUNNER" "unittest")
> > +             (setenv "PYTHONHASHSEED" "random")
> > +             (and
> > +               ;; Test without c extensions
> > +               ;; FIXME someone already called build_ext.
> > +               ;(zero? (system* "python" "-m" "unittest" 
> > "dulwich.tests.test_suite"))
> > +               ;; Test with c extensions
> > +               ;(zero? (system* "python" "setup.py" "build_ext" "-i"))  
> 
> I think build_ext is called as part of the regular build process. Why
> does it need to be called again (with the -i flag)?

It's copied from the .travis file. Since we install the C extension so we 
should also test the C extension - and the other test doesn't matter. But I'm 
unsure whether to leave the comment in.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]