[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] import: github: Catch HTTP 403 error during fetch.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH] import: github: Catch HTTP 403 error during fetch. |
|
Date: |
Thu, 19 Jan 2017 17:19:13 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Mathieu OTHACEHE <address@hidden> skribis:
> * guix/import/github.scm (json-fetch*): Catch 403 HTTP error that may be
> raised if a github token has not been set.
>
> Signed-off-by: Mathieu OTHACEHE <address@hidden>
> ---
>
> Hi,
>
> If too many github requests are made during a guix refresh (> 60/h),
> github will reject all further requests with a 403 error.
>
> The 403 error is not catch in json-fetch* guard, so guix refresh
> will exit at that point. The user never gets to error message
> informing that setting a GUIX_GITHUB_TOKEN may fix the problem.
Looks like the right to do indeed. Applied, thanks!
Ludo’.