Re: [PATCH] gnu: Add kakoune

[Ludovic Courtès]

Hello,

Sorry for the delay.

Carlo Zancanaro <address@hidden> skribis:

> From a15396f186d5a88f7fbe1af21add9bbd40ddc59b Mon Sep 17 00:00:00 2001
> From: Carlo Zancanaro <address@hidden>
> Date: Fri, 30 Dec 2016 02:15:59 +1100
> Subject: [PATCH] gnu: Add kakoune
>
> * gnu/packages/patches/kakoune-leave-manpages-uncompressed.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register patch.
> * gnu/packages/text-editors.scm (kakoune): New variable.

[...]

> +++ b/gnu/packages/patches/kakoune-leave-manpages-uncompressed.patch
> @@ -0,0 +1,69 @@
> +Kakoune compresses its manpages, which makes the build non-reproducible (as 
> it
> +leaves timestamps in files). If we don't do that here, and instead do it in
> +the guix phases `compress-manpages` then the build is reproducible.
> +
> +--- a/src/Makefile
> ++++ b/src/Makefile
> +@@ -22,7 +22,7 @@
> + objects := $(addprefix ., $(sources:.cc=$(suffix).o))
> + deps := $(addprefix ., $(sources:.cc=$(suffix).d))
> + docs := $(wildcard ../doc/manpages/*.asciidoc)
> +-mandocs := $(docs:.asciidoc=.gz)
> ++mandocs := $(docs:.asciidoc=.1)
> + 
> + PREFIX ?= /usr/local
> + DESTDIR ?= # root dir
> +@@ -76,19 +76,17 @@
> +     $(CXX) $(CPPFLAGS) $(CXXFLAGS) -MD -MP -MF $(addprefix ., 
> $(<:.cc=$(suffix).d)) -c -o $@ $<
> + 
> + # Generate the man page
> +-../doc/kak.1.gz: ../doc/kak.1.txt
> ++../doc/kak.1: ../doc/kak.1.txt
> +     a2x --no-xmllint -f manpage $<
> +-    gzip -f $(basename $<)

It’s simpler to add --no-name (which suppresses timestamps and file
names from the gzip output) to all the gzip invocation in this Makefile.

Could you do that?

In ‘core-updates’ I’d like to add a phase that clears timestamps and
file names from all gzip headers so we don’t have to bother.

Thanks!

Ludo’.