Re: [PATCH 1/2] gnu: Add openvswitch.

[Ludovic Courtès]

Hi 宋文武!

宋文武 <address@hidden> skribis:

> * gnu/packages/networking.scm (openvswitch): New variable.

[...]

> +     '(;; FIXME: many tests fail with:
> +       ;;    […]
> +       ;;    test -e $OVS_RUNDIR/ovs-vswitchd.pid
> +       ;;    ovs-appctl -t ovs-vswitchd exit
> +       ;;    hard failure
> +       #:tests? #f

Can we assume that the failures are due to the lack of a proper
networking environment?  Do they pass outside of the chroot?

It would be good to have a rough idea of why they fail.

> +         (replace 'install
> +           (lambda _
> +             (zero? (system* "make"
> +                             "RUNDIR=/tmp"
> +                             "PKIDIR=/tmp"
> +                             "LOGDIR=/tmp"
> +                             "DBDIR=/tmp"
> +                             "install")))))))

I suppose this is to prevent “mkdir /var/log” or similar, right?
Perhaps worth mentioning in a comment.

The rest LGTM.

Thanks!

Ludo’.