Re: [PATCH] gnu: dub: Patch pkg-config name.

[Ludovic Courtès]

Danny Milosavljevic <address@hidden> skribis:

> * gnu/packages/ldc.scm (dub)[arguments]: Add 'patch-paths' phase.
> ---
>  gnu/packages/ldc.scm | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/ldc.scm b/gnu/packages/ldc.scm
> index 4b10ac25e..e131c473d 100644
> --- a/gnu/packages/ldc.scm
> +++ b/gnu/packages/ldc.scm
> @@ -32,6 +32,7 @@
>    #:use-module (gnu packages gdb)
>    #:use-module (gnu packages libedit)
>    #:use-module (gnu packages llvm)
> +  #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages textutils)
>    #:use-module (gnu packages zip))
> @@ -293,6 +294,12 @@ latest DMD frontend and uses LLVM as backend.")
>       `(#:tests? #f ; it would have tested itself by installing some packages 
> (vibe etc)
>         #:phases
>         (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-paths
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (substitute* "source/dub/compilers/utils.d"
> +               ; TODO patch source/dub/platform.d compiler executable name ??
> +               (("enum pkgconfig_bin = \"pkg-config\";") (string-append 
> "enum pkgconfig_bin = \"" (assoc-ref inputs "pkg-config") 
> "/bin/pkg-config\";")))
> +             #t))

Is it necessary?  It might be a case where picking whatever’s in $PATH
(“late binding”) is good enough; for instance, ‘gcc’ picks ‘ld’ from
$PATH, and that’s fine.

WDYT?

(Besides, shorter lines please, and s/path/file name/.)

Ludo’.