Re: [PATCH 2/2] gnu: Add python-lzo.

[Hartmut Goebel]

Am 02.02.2017 um 16:16 schrieb address@hidden:
> +                (string-append "include_dirs.append(\""
> +                               (assoc-ref %build-inputs "lzo") 
> "/include/lzo" "\")

You could use single quotes for teh python string to make it more readable:


string-append "include_dirs.append('" + (assoc-ref %build-inputs "lzo")
"/include/lzo" "')


> +"))))))))

Also this line-break is confusing. I suggest either using "\n" or to
change the substitute into something like:


+             (substitute* "setup.py"
+               (("include_dirs.append\(.*\)")  ;; match up to the trailing 
parent only, not the new-line
+                (string-append "include_dirs.append('"
+                               (assoc-ref %build-inputs "lzo") "/include/lzo"
+                               "')"))))))))   ;; put these last few characters 
on the next line

Otherwise LGTM.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | address@hidden               |
| www.crazy-compilers.com | compilers which you thought are impossible |

0xBF773B65.asc
Description: application/pgp-keys