Re: [PATCH] gnu: Add emacs-pretty-mode.

[Alex Kost]

ng0 (2017-02-02 10:08 +0000) wrote:

> Alex Kost writes:
>
>> address@hidden (2017-02-01 18:08 +0000) wrote:
>>
>>> From: ng0 <address@hidden>
>>>
>>> * gnu/packages/emacs.scm (emacs-pretty-mode): New variable.
>>> ---
>>>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>>>  1 file changed, 23 insertions(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index df7f7869d..a51b5de1d 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -3778,3 +3778,26 @@ customizable by the user.")
>>>  Additionally it can display the number of unread emails in the
>>>  mode-line.")
>>>      (license license:gpl3+)))
>>> +
>>> +(define-public emacs-pretty-mode
>>> +  (let ((commit "500085206e25b98d00b9ec996f91c87ba569c4ce")
>>> +        (revision "1"))
>>> +  (package
>>> +    (name "emacs-pretty-mode")
>>> +    (version (string-append "2.0.3-" revision "." (string-take commit 7)))
>>> +    (source
>>> +     (origin
>>> +       (method git-fetch)
>>> +       (uri (git-reference
>>> +             (url "https://github.com/akatov/pretty-mode";)
>>> +             (commit commit)))
>>
>> Why git commit, and not the latest snapshot?
>>
>> https://github.com/akatov/pretty-mode/archive/2.0.3.tar.gz
>
> I wasn't sure. Melpa uses a git commit (I think) and the last
> release is very old. I picked the commit because I thought it
> would be incompatible to current emacs.

Of course it is compatible.  Melpa always uses the latest commit.  And
Melpa-Stable uses the latest tag (which is 2.0.3):

  http://stable.melpa.org/#/pretty-mode

My understanding of Guix packaging policy is that we try to package the
latest releases (or latest tag snapshots if there is no release
tarball), and to use git commits only if there are significant bug or
security fixes.  Otherwise, why don't we use git-fetch everywhere?

BTW it is not "very old", it is 10 commits behind master, and all these
commits are rather minor, as you can see:

  https://github.com/akatov/pretty-mode/compare/2.0.3...master

>>> +       (file-name (string-append name "-" version "-checkout"))
>>> +       (sha256
>>> +        (base32
>>> +         "0m7ii971zxlz8a9yx2ljf9fmd8k6hc9w1q8mi5xi32v9viccjabs"))))
>>> +    (build-system emacs-build-system)
>>> +    (home-page "https://github.com/akatov/pretty-mode";)
>>> +    (synopsis "Redisplay parts of the buffer as pretty Unicode symbols.")
>>> +    (description
>>> +     "Emacs minor mode for redisplaying parts of the buffer as pretty 
>>> symbols.")
>>> +    (license license:gpl3+))))

-- 
Alex