guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add tftp-hpa.


From: Thomas Danckaert
Subject: Re: [PATCH] gnu: Add tftp-hpa.
Date: Mon, 06 Feb 2017 22:16:14 +0100 (CET)

From: Boskovits, Gábor <address@hidden>
Subject: [PATCH] gnu: Add tftp-hpa.
Date: Mon,  6 Feb 2017 00:33:31 +0100

---
 gnu/packages/tftp-hpa.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

Hi!

I tested the patch and the package builds fine.

+    (description
+ "This is a tftp client derived from OpenBSD tftp with some extra options +added and bugs fixed. The source includes readline support but it is not +enabled due to licence conflicts between the BSD advertising clause and the GPL.")

“licence”->“license”

[...]
I would like to get some assistance in selecting a category for this
package.

I'll let someone else comment on this :).

Should it be networking, or something else?

I would be glad if someone could also verify if my licese selection
is correct.

Af for the license issues: I think bsd-4 is correct, but about the disabled GPL code: I think you can actually distribute a combined work of GPL and BSD as GPL, as long as you specify that the BSD parts of it are also BSD-licensed? In the package's license field, you could say "(license (list gpl1 bsd-4))"

If you send an updated patch, you will also be asked to follow the gnu commit message guidelines (take a look at the log for inspiration). Your commit title would be something like “gnu: Add tftp-hpa.” and the body will mention the new variable.

cheers,

Thomas

reply via email to

[Prev in Thread] Current Thread [Next in Thread]