Re: [PATCH 2/5] gnu: Add tidy-html.

[Kei Kebreau]

address@hidden writes:

> From: ng0 <address@hidden>
>
> * gnu/packages/web.scm (tidy-html): New variable.
> ---
>  gnu/packages/web.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 50 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 67b9797bb..8a29eead1 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -13,7 +13,7 @@
>  ;;; Copyright © 2016 Rene Saavedra <address@hidden>
>  ;;; Copyright © 2016 Ben Woodcroft <address@hidden>
>  ;;; Copyright © 2016 Clément Lassieur <address@hidden>
> -;;; Copyright © 2016 ng0 <address@hidden>
> +;;; Copyright © 2016, 2017 ng0 <address@hidden>
>  ;;; Copyright © 2016 Arun Isaac <address@hidden>
>  ;;; Copyright © 2016 Tobias Geerinckx-Rice <address@hidden>
>  ;;; Copyright © 2016 Bake Timmons <address@hidden>
> @@ -3995,3 +3995,52 @@ programs' code.  Its architecture is optimized for 
> security, portability, and
>  scalability (including load-balancing), making it suitable for large
>  deployments.")
>    (license l:gpl2+)))
> +
> +(define-public tidy-html
> +  (package
> +    (name "tidy-html")
> +    (version "5.2.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/htacg/tidy-html5/archive/";
> +                           version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0kbwzh15dlapp3s3vff2qgz0yfcf8hwsnx5q4igwa6pimhak8lw0"))))
> +    (build-system cmake-build-system)
> +    (outputs '("out"
> +               "static")) ; 1.0MiB of .a files
> +    (arguments
> +     `(#:tests? #f ; No tests available
> +       #:configure-flags (list "-DCMAKE_BUILD_TYPE=Release")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'move-static-libraries
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             ;; Move static libraries to the "static" output.
> +             (let* ((out    (assoc-ref outputs "out"))
> +                    (lib    (string-append out "/lib"))
> +                    (static (assoc-ref outputs "static"))
> +                    (slib   (string-append static "/lib")))
> +               (mkdir-p slib)
> +               (for-each (lambda (file)
> +                           (install-file file slib)
> +                           (delete-file file))
> +                         (find-files lib "\\.a$"))
> +               #t))))))
> +    (native-inputs
> +     `(("libxslt" ,libxslt)))
> +    (home-page "http://www.html-tidy.org/";)
> +    (synopsis "HTML Tidy with HTML5 support")
> +    (description
> +     "Tidy is a console application for Mac OS X, Linux, Windows,
> +UNIX, and more. It corrects and cleans up HTML and XML documents by
> +fixing markup errors and upgrading legacy code to modern standards.
> +
> +libtidy is a C static and dynamic library that developers can integrate
> +into their applications in order to bring all of Tidy’s power to your
> +favorite tools. libtidy is used today in desktop applications,
> +web servers, and more.")

Sentences in the description should be followed by two spaces.

> +    (license l:bsd-3)))

The rest LGTM.

signature.asc
Description: PGP signature