Re: [PATCH 2/2] tests: Add 'prosody-service-type' test.

[Ludovic Courtès]

Hello Clément,

Clément Lassieur <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:

[...]

>>> +(define (run-xmpp-test name xmpp-service pid-file create-account)
>>> +  "Run a test of an OS running XMPP-SERVICE, which writes its PID to 
>>> PID-FILE."
>>> +  (mlet* %store-monad ((os -> (marionette-operating-system
>>> +                               (os-with-service xmpp-service)
>>> +                               #:imported-modules '((gnu services herd))))
>>
>> I think you can remove ‘os-with-service’ and simply add the Prosody
>> service explicitly in ‘%base-os’ (which could be rename ‘%prosody-os’
>> maybe).
>
> But then, my test wouldn't be generic anymore, would it?  I would like
> it to be Prosody-independent, so that one can add, say, the ejabberd
> service easily.  That's why I call the service 'xmpp-daemon' instead of
> 'prosody'.  WDYT?

I think you’re right.  :-)  I didn’t know you had this in mind, but it’s
a good idea.

Ludo’.