guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] website: packages: Anchor location url to commit id.


From: Ludovic Courtès
Subject: Re: [PATCH] website: packages: Anchor location url to commit id.
Date: Tue, 14 Feb 2017 17:20:23 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

ng0 <address@hidden> skribis:

> On 17-02-13 15:35:25, Ludovic Courtès wrote:
>> address@hidden skribis:
>> 
>> > From: Eric Bavier <address@hidden>
>> >
>> > * website/www/packages.scm (git-description): New variable.
>> > (location-url): Include "?id=..." if possible.
>> 
>> Looks like a good idea, please push!
>> 
>> Thanks,
>> Ludo'.
>> 
> As a follow-up I think we could also use this now:
>
> (string-append "//git.savannah.gnu.org/cgit/guix.git/tree/"
>                (location-file loc) "#n"
>                (number->string (location-line loc))))
>
> And the same for other instances of git.savannah.gnu.org,
> what do you think?

Good idea.  Done in commit f3ad5e8422b6375029e1526eeb9ea2909b157181 of
guix-artwork.git.

> There are other "http" in the pages which could be replaced with // as
> well (for example hydra.gnu.org).

Don’t hesitate to send a patch if you spot other similar issues.

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]