guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Guix-devel Digest, Vol 44, Issue 146


From: Chaitan Rogers
Subject: Re: Guix-devel Digest, Vol 44, Issue 146
Date: Sat, 18 Feb 2017 20:05:53 +0000

A

Get Outlook for Android



From: Guix-devel <guix-devel-bounces+address@hidden> on behalf of address@hidden <address@hidden>
Sent: Saturday, February 18, 2017 7:26:27 PM
To: address@hidden
Subject: Guix-devel Digest, Vol 44, Issue 146
 
Send Guix-devel mailing list submissions to
        address@hidden

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.gnu.org/mailman/listinfo/guix-devel
or, via email, send a message with subject or body 'help' to
        address@hidden

You can reach the person managing the list at
        address@hidden

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Guix-devel digest..."


Today's Topics:

   1. python-tests: python-oslosphinx fixed. Please evaluate.
      (Danny Milosavljevic)
   2. ntfs-3g: Does it build? (Danny Milosavljevic)
   3. Re: updating many haskell packages (Troy Sankey)
   4. Re: [PATCH 2/2] services: openssh: Remove deprecated
      'RSAAuthentication' option. (Cl?ment Lassieur)
   5. Re: [PATCH 2/2] services: openssh: Remove deprecated
      'RSAAuthentication' option. (Cl?ment Lassieur)
   6. Re: 01/01: updated pioneers to latest version. (Leo Famulari)
   7. Re: [PATCH] update pioneers to latest version. (Kei Kebreau)
   8. Re: 01/01: updated pioneers to latest version. (Kei Kebreau)


----------------------------------------------------------------------

Message: 1
Date: Sat, 18 Feb 2017 18:18:54 +0100
From: Danny Milosavljevic <address@hidden>
To: address@hidden, Leo Famulari <address@hidden>
Subject: python-tests: python-oslosphinx fixed. Please evaluate.
Message-ID: <address@hidden>
Content-Type: text/plain; charset=US-ASCII

Hi,

so we finally got to the bottom of the problem with python-oslosphinx. It should be fixed now (the main fix is in python-pbr-minimal).

@Leo: Can you please start a new evaluation of python-tests?



------------------------------

Message: 2
Date: Sat, 18 Feb 2017 18:32:55 +0100
From: Danny Milosavljevic <address@hidden>
To: address@hidden
Subject: ntfs-3g: Does it build?
Message-ID: <address@hidden>
Content-Type: text/plain; charset=US-ASCII

Hi,

does ntfs-3g build for you using Guix master?

For me, it doesn't - because of a whitespace problem in the patch "ntfs-3g-CVE-2017-0358.patch".



------------------------------

Message: 3
Date: Sat, 18 Feb 2017 12:40:15 -0500
From: Troy Sankey <address@hidden>
To: Federico Beffa <address@hidden>,
Cc: "Guix-devel" <address@hidden>
Subject: Re: updating many haskell packages
Message-ID: <address@hidden>
Content-Type: text/plain; charset="utf-8"

Quoting Federico Beffa (2017-02-18 04:43:51)
> On Fri, Feb 17, 2017 at 6:47 PM, Troy Sankey <address@hidden> wrote:
> > Forgive me if my understanding of build systems in Guix is flawed, but
> > let me explain my idea with more detail:
> >
> > First, make a data-only package called "ghc-all-cabal-files" containing
> > the checkout of a specific commit of the all-cabal-files repository from
> > github.  We can periodically update this package, but there is no
> > traditional "release"---we just keep pulling the HEAD of the hackage
> > branch.  This package would then act as a helper package for the haskell
> > build system---every haskell package should implicitly use this package
> > as input.  Then we can write a post-unpack phase for the
> > haskell-build-system which updates the unpacked .cabal file iff it finds
> > a newer .cabal file in ghc-all-cabal-files (we know how to determine if
> > the cabal file is newer: it will have a higher "x-revision" value, or
> > that key will merely exist).
> >
> > One problem I have not fully solved is the technical debt associated
> > with keeping the proposed ghc-all-cabal-files package up-to-date.  I
> > believe updating it would require all haskell packages to be rebuilt.
> > We could create a build system argument called use-newest-cabal-file to
> > toggle the feature, in which case we would only switch it to #t if we
> > already know the .cabal file to be stale.  Then only a small subset of
> > packages would need to be rebuilt, and there is less technical debt than
> > the current solution which involves monkey-patching every cabal file
> > that needs it.
>
> My worry with this approach is that every time that a single cabal
> file in 'ghc-all-cabal-files' is updated all packages will fail to
> build (the implicit input will fail). Given that there are several
> thousands of cabal files, I suspect that this could occur quite often.

Can you elaborate on how all packages will fail to build?

Also, my hope is that with the toggle switch 'use-newest-cabal-file' we
do not have to make ghc-all-cabal-files an implicit input for all
haskell packages, only a few.

> Maybe another approach could be: when we update the GHC packages we
> follow a specific Stackage release. If a package tar includes an old
> cabal file, we enable a 'jailbreak' flag such that the build system
> clears version bounds. This of course relies on the fact that Stackage
> verified that this is fine.

What you describe is almost what I mean.  It is a fine alternative
solution, and I would be open to implementing this for the immediate
term.

My approach implies that we use Stackage LTS, but instead of "jailbreak"
use "use-newest-cabal-file" since the newer cabal file often will
include those relaxed version bounds, so the effect is almost the same.
The newer cabal file may also contain other changes unrelated to
dependency version bounds [0] and those changes are implicitly verified
by Stackage LTS which also uses newer cabal files.  In fact, by not
using the updated cabal files, we are essentially diverging from the
Stackage LTS.

Remember, all-cabal-files tracks cabal revisions for every package
version.  If Stackage LTS references an old version of a haskell
package, then we can still find the "latest" cabal file for that old
version of the package in all-cabal-files.

There is one more problem, and it is not a minor problem...

------------------------------- cut here -------------------------------
$ du -hs tmp/all-cabal-files
862M    tmp/all-cabal-files
$ du -hs tmp/all-cabal-files/.git
140M    tmp/all-cabal-files/.git
$ echo '862 - 140' | bc
722
------------------------------- cut here -------------------------------

The filesize of the package output will be 722 MiB.  We could prune it
of all the unrelated versions according to the stackage LTS, but this
starts to get complicated and error-prone...

Troy

[0] https://www.haskell.org/cabal/users-guide/developing-packages.html#build-information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://lists.gnu.org/archive/html/guix-devel/attachments/20170218/ea193407/attachment.pgp>

------------------------------

Message: 4
Date: Sat, 18 Feb 2017 19:07:08 +0100
From: Cl?ment Lassieur <address@hidden>
To: Ricardo Wurmus <address@hidden>
Cc: address@hidden
Subject: Re: [PATCH 2/2] services: openssh: Remove deprecated
        'RSAAuthentication' option.
Message-ID: <address@hidden>
Content-Type: text/plain; charset=utf-8

Ricardo Wurmus <address@hidden> writes:
> Cl?ment Lassieur <address@hidden> writes:
>
>> * gnu/services/ssh.scm (openssh-config-file): Remove it.
>>   (<openssh-configuration>)[rsa-authentication?]: Remove it.
>> * doc/guix.texi (Networking Services): Remove it.
>
> I don?t see ?openssh-config-file? in the diff.  Is this missing or a
> mistake in the commit summary?  Or am I misunderstanding?

I meant: remove "RSAAuthentication" from the "openssh-config-file"
computed file.  It refers to the third hunk.  I wasn't sure how to
express this.  Please correct me, if I was wrong :)



------------------------------

Message: 5
Date: Sat, 18 Feb 2017 19:32:15 +0100
From: Cl?ment Lassieur <address@hidden>
To: Ricardo Wurmus <address@hidden>
Cc: address@hidden
Subject: Re: [PATCH 2/2] services: openssh: Remove deprecated
        'RSAAuthentication' option.
Message-ID: <address@hidden>
Content-Type: text/plain; charset=utf-8

Ricardo Wurmus <address@hidden> writes:
> Cl?ment Lassieur <address@hidden> writes:
>
>> * gnu/services/ssh.scm (openssh-config-file): Remove it.
>>   (<openssh-configuration>)[rsa-authentication?]: Remove it.
>> * doc/guix.texi (Networking Services): Remove it.
>> ---
>>  doc/guix.texi        | 5 -----
>>  gnu/services/ssh.scm | 5 -----
>>  2 files changed, 10 deletions(-)
>>
>> diff --git a/doc/guix.texi b/doc/guix.texi
>> index 22eef3a64..54d4bab89 100644
>> --- a/doc/guix.texi
>> +++ b/doc/guix.texi
>> @@ -9151,11 +9151,6 @@ false, users have to use other authentication method.
>>  Authorized public keys are stored in @file{~/.ssh/authorized_keys}.
>>  This is used only by protocol version 2.
>>
>> address@hidden @code{rsa-authentication?} (default: @code{#t})
>> -When true, users may log in using pure RSA authentication.  When false,
>> -users have to use other means of authentication.  This is used only by
>> -protocol 1.
>> -
>
> Is it still possible to make SSH use protocol 1 or has this feature
> disappeared?  If it is still possible I think we should not remove this
> option.

Quote from https://www.openssh.com/releasenotes.html (about OpenSSH
7.4/7.4p1, which is the one we use):

    * This release removes server support for the SSH v.1 protocol.

So I think it is not possible anymore.



------------------------------

Message: 6
Date: Sat, 18 Feb 2017 14:11:17 -0500
From: Leo Famulari <address@hidden>
To: address@hidden
Subject: Re: 01/01: updated pioneers to latest version.
Message-ID: <address@hidden>
Content-Type: text/plain; charset="us-ascii"

On Sat, Feb 18, 2017 at 01:59:34PM -0500, Kei Kebreau wrote:
> kkebreau pushed a commit to branch master
> in repository guix.
>
> commit 2f7eccc048de6526ef3f4c2de1c67ea0455ccb0c
> Author: Rodger Fox <address@hidden>
> Date:   Fri Feb 17 20:01:37 2017 -0800
>
>     updated pioneers to latest version.
>    
>     Signed-off-by: Kei Kebreau <address@hidden>

Thanks for the contribution Rodger!

For future patches, please note the section of the manual called
Submitting Patches. It briefly explains that we have a standard format
for commit messages, which this commit does not follow.

https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html#Submitting-Patches

For an example of how this commit message should have been written, see
this recent commit updating webkitgtk:

    gnu: webkitgtk: Update to 2.14.5.
   
    * gnu/packages/webkit.scm (webkitgtk): Update to 2.14.5.

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=42e721a13d6f47397e585f5909d140c4bafb4ad0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.gnu.org/archive/html/guix-devel/attachments/20170218/93b0c5a4/attachment.pgp>

------------------------------

Message: 7
Date: Sat, 18 Feb 2017 14:22:57 -0500
From: Kei Kebreau <address@hidden>
To: Rodger Fox <address@hidden>
Cc: address@hidden
Subject: Re: [PATCH] update pioneers to latest version.
Message-ID: <address@hidden>
Content-Type: text/plain; charset="us-ascii"

Rodger Fox <address@hidden> writes:

> This is a simple version update. I attached the patch file.
Looks good! Pushed to master as 365950ce92f27781086ecd99d1efa99d484e7de0.
Also, make sure to use the GNU change log format[0]. It makes changes
easier to understand for everyone. Thanks!

[0]: https://www.gnu.org/prep/standards/html_node/Change-Logs.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.gnu.org/archive/html/guix-devel/attachments/20170218/4b6aa96e/attachment.pgp>

------------------------------

Message: 8
Date: Sat, 18 Feb 2017 14:26:16 -0500
From: Kei Kebreau <address@hidden>
To: Leo Famulari <address@hidden>
Cc: address@hidden
Subject: Re: 01/01: updated pioneers to latest version.
Message-ID: <address@hidden>
Content-Type: text/plain; charset="us-ascii"

Leo Famulari <address@hidden> writes:

> On Sat, Feb 18, 2017 at 01:59:34PM -0500, Kei Kebreau wrote:
>> kkebreau pushed a commit to branch master
>> in repository guix.
>>
>> commit 2f7eccc048de6526ef3f4c2de1c67ea0455ccb0c
>> Author: Rodger Fox <address@hidden>
>> Date:   Fri Feb 17 20:01:37 2017 -0800
>>
>>     updated pioneers to latest version.
>>    
>>     Signed-off-by: Kei Kebreau <address@hidden>

For the record, I reverted this commit and pushed a correctly written one.
I don't know how much that matters.

>
> Thanks for the contribution Rodger!
>
> For future patches, please note the section of the manual called
> Submitting Patches. It briefly explains that we have a standard format
> for commit messages, which this commit does not follow.
>
> https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html#Submitting-Patches
>
> For an example of how this commit message should have been written, see
> this recent commit updating webkitgtk:
>
>     gnu: webkitgtk: Update to 2.14.5.
>    
>     * gnu/packages/webkit.scm (webkitgtk): Update to 2.14.5.
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=42e721a13d6f47397e585f5909d140c4bafb4ad0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.gnu.org/archive/html/guix-devel/attachments/20170218/113467e7/attachment.pgp>

------------------------------

Subject: Digest Footer

_______________________________________________
Guix-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/guix-devel


------------------------------

End of Guix-devel Digest, Vol 44, Issue 146
*******************************************

reply via email to

[Prev in Thread] Current Thread [Next in Thread]