[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] services: openssh: Fix 'PrintLastLog' default behaviour.
|
From: |
Danny Milosavljevic |
|
Subject: |
Re: [PATCH 3/4] services: openssh: Fix 'PrintLastLog' default behaviour. |
|
Date: |
Thu, 2 Mar 2017 08:37:05 +0100 |
Hi,
On Tue, 21 Feb 2017 00:53:54 +0100
Clément Lassieur <address@hidden> wrote:
> * gnu/services/ssh.scm (openssh-config-file): Add 'pring-last-log?' option.
^ typo
> (<openssh-configuration>)[print-last-log?]: Add it.
> (openssh-activation): Touch /var/log/lastlog.
Indentation is too much here.
> * doc/guix.texi (Networking Services): Document 'pring-last-log?'.
^ typo
> + (let ((lastlog "/var/log/lastlog"))
> + (when #$(openssh-configuration-print-last-log? config)
> + (unless (file-exists? lastlog)
> + (touch lastlog))))
> +
Hmm. What about the permissions? Are they OK?
Otherwise LGTM!