[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] services: openssh: Fix 'PrintLastLog' default behaviour.
|
From: |
Clément Lassieur |
|
Subject: |
Re: [PATCH 3/4] services: openssh: Fix 'PrintLastLog' default behaviour. |
|
Date: |
Thu, 02 Mar 2017 22:03:52 +0100 |
|
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
Danny Milosavljevic <address@hidden> writes:
> Hi,
>
> On Tue, 21 Feb 2017 00:53:54 +0100
> Clément Lassieur <address@hidden> wrote:
>
>> * gnu/services/ssh.scm (openssh-config-file): Add 'pring-last-log?' option.
> ^ typo
Done.
>> (<openssh-configuration>)[print-last-log?]: Add it.
>> (openssh-activation): Touch /var/log/lastlog.
>
> Indentation is too much here.
Done, on other patches too.
>> * doc/guix.texi (Networking Services): Document 'pring-last-log?'.
> ^ typo
Done.
>> + (let ((lastlog "/var/log/lastlog"))
>> + (when #$(openssh-configuration-print-last-log? config)
>> + (unless (file-exists? lastlog)
>> + (touch lastlog))))
>> +
>
> Hmm. What about the permissions? Are they OK?
The permissions are OK (644, root:root).
> Otherwise LGTM!
Thank you!
I'll answer this with the three openssh updated patches.