guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH -v2 2/2] guix: profiles: create fonts.dir/scale for all fonts


From: huang ying
Subject: Re: [PATCH -v2 2/2] guix: profiles: create fonts.dir/scale for all fonts directories
Date: Wed, 8 Mar 2017 15:44:47 +0800

On Wed, Mar 8, 2017 at 4:24 AM, Danny Milosavljevic
<address@hidden> wrote:
> Hi,
>
>> +                            (with-directory-excursion dir
>> +                              (and (file-exists? fonts-scale-file)
>> +                                   (delete-file fonts-scale-file))
>> +                              (and (file-exists? fonts-dir-file)
>> +                                   (delete-file fonts-dir-file))
>> +                              (system* mkfontscale)
>> +                              (system* mkfontdir)
>
> Please do not throw away the status code here (result of system*). You can 
> check for okayness by (zero? (system* ...)).

Then what is the intended behavior?  abort the build process with
message and non-zero exit code?  Usually we will raise a exception or
just display some message and exit?

Best Regards,
Huang, Ying



reply via email to

[Prev in Thread] Current Thread [Next in Thread]