Re: Build-side code with non-ASCII failing to build on Hydra

[Ludovic Courtès]

Hi Mark,

Mark H Weaver <address@hidden> skribis:

> On the security-updates jobset on Hydra, I'm seeing several new build
> failures due to non-ASCII characters within build-side code being
> misread:
>
>   https://hydra.gnu.org/build/2003897
>   https://hydra.gnu.org/build/2001256
>   https://hydra.gnu.org/build/2013954
>   https://hydra.gnu.org/build/2006487
>   https://hydra.gnu.org/eval/109617?compare=109613#tabs-now-fail
>
> Has something changed recently that might explain this?

That’s surprising.  On current master, on my laptop, utf8proc fails
exactly as shown in <https://hydra.gnu.org/build/2003897>:

--8<---------------cut here---------------start------------->8---
starting phase `check-data'

[...]

In 
/gnu/store/a42pfdz8w5qxdkp6xz8783ydywmp0p8p-module-import/guix/build/utils.scm:
 612: 1 [#<procedure c303a0 at 
/gnu/store/a42pfdz8w5qxdkp6xz8783ydywmp0p8p-module-import/guix/build/utils.scm:608:23
 (expr)> #]
In unknown file:
   ?: 0 [make-regexp "?" 1]

ERROR: In procedure make-regexp:
ERROR: In procedure make-regexp: Invalid preceding regular expression
--8<---------------cut here---------------end--------------->8---

Yet Hydra says it succeeded on ‘master’:

  https://hydra.gnu.org/job/gnu/master/utf8proc-2.1.0.x86_64-linux

Indeed, the latest one that succeeded on x86_64 also works for me:

  $ guix build /gnu/store/cxwa18q2sa69i08982rb0dd73lph2spz-utf8proc-2.1.0.drv
  /gnu/store/mf2bby0nzzsq2x5m654g89yxd3l9h6v8-utf8proc-2.1.0

The one in current master is different:

  $ ./pre-inst-env guix build utf8proc -d --no-grafts
  /gnu/store/133cl1mzwa3dzy5s3ihr90qspp7l6g96-utf8proc-2.1.0.drv
  address@hidden ~/src/guix$ git describe
  v0.12.0-3158-g285f63e80

The difference is that one of the builders is UTF-8-encoded whereas the
other is Latin-1:

  $ diffoscope 
"/gnu/store/msbh42cr1f48z6hc24h5v9vpl18l5hhz-utf8proc-2.1.0-guile-builder" 
"/gnu/store/r9y6fma06w4ghz00nws372iqxcszpv25-utf8proc-2.1.0-guile-builder"
  --- /gnu/store/msbh42cr1f48z6hc24h5v9vpl18l5hhz-utf8proc-2.1.0-guile-builder
  +++ /gnu/store/r9y6fma06w4ghz00nws372iqxcszpv25-utf8proc-2.1.0-guile-builder
  ├── encoding
  │ @@ -1 +1 @@
  │ -iso-8859-1
  │ +utf-8

This is fixed by commit 9231ef12f2a595b8f1e677dbe50cc499555302b6 in
‘master’.

Thanks for the heads-up, and sorry for the breakage!

Ludo’.