[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 01/01: gnu: totem: Enable parallel build.
From: |
Kei Kebreau |
Subject: |
Re: 01/01: gnu: totem: Enable parallel build. |
Date: |
Mon, 13 Nov 2017 07:49:02 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Mark H Weaver <address@hidden> writes:
> Hi,
>
> address@hidden (Kei Kebreau) writes:
>
>> kkebreau pushed a commit to branch master
>> in repository guix.
>>
>> commit e5f748a6c0c774265f52c7246ee7b80bec6d3522
>> Author: Kei Kebreau <address@hidden>
>> Date: Wed Nov 8 20:42:20 2017 -0500
>>
>> gnu: totem: Enable parallel build.
>>
>> * gnu/packages/gnome.scm (totem)[arguments]: Set #:parallel-build? to #t
>> implicitly.
>
> Your commit reverted the preceding commit made to our 'totem' package,
> namely:
>
>> commit a97bfa46cdb782f705204a50a10bca9fa98c56b2
>> Author: Adam Van Ymeren <address@hidden>
>> Date: Fri Oct 13 12:40:50 2017 -0400
>>
>> gnu: totem: Disable parallel build due to http://debbugs.gnu.org/28813
>>
>> Fixes <http://bugs.gnu.org/28813>.
>>
>> * gnu/packages/gnome.scm (totem)[arguments]: Add #:parallel-build?.
>>
>> Signed-off-by: Ludovic Courtès <address@hidden>
>
> Unsurprisingly, this caused bug #28813 to re-appear. Since reverting
> this fix, one of the totem builds failed on Hydra with the same error
> message described in <https://bugs.gnu.org/28813>:
>
> https://hydra.gnu.org/build/2352092
>
> namely:
>
> [124/150] Compiling Vala source
> ../totem-3.26.0/src/plugins/sample-vala/totem-sample-vala-plugin.vala.
> FAILED: src/plugins/sample-vala/address@hidden/totem-sample-vala-plugin.c
> src/plugins/sample-vala/sample-vala.h
> src/plugins/sample-vala/sample-vala.vapi
> valac -C --pkg libpeas-1.0 --pkg gtk+-3.0 -d
> src/plugins/sample-vala/address@hidden --library=sample-vala -H
> src/plugins/sample-vala/sample-vala.h --vapi ../sample-vala.vapi
> --girdir=/tmp/guix-build-totem-3.26.0.drv-0/build/src --pkg=Totem-1.0
> ../totem-3.26.0/src/plugins/sample-vala/totem-sample-vala-plugin.vala
> error: Package `Totem-1.0' not found in specified Vala API directories or
> GObject-Introspection GIR directories
> Compilation failed: 1 error(s), 0 warning(s)
> [125/150] Linking target src/plugins/ontop/libontop.so.
> [126/150] Linking target src/totem.
> [127/150] Generating Totem-1.0.gir with a custom command.
> ninja: build stopped: subcommand failed.
> phase `build' failed after 15.8 seconds
> builder for `/gnu/store/l6pv9v3kvvbj4dfnmqj2irmqzwa9hw4c-totem-3.26.0.drv'
> failed with exit code 1
> @ build-failed /gnu/store/l6pv9v3kvvbj4dfnmqj2irmqzwa9hw4c-totem-3.26.0.drv -
> 1 builder for `/gnu/store/l6pv9v3kvvbj4dfnmqj2irmqzwa9hw4c-totem-3.26.0.drv'
> failed with exit code 1
>
> I'd like to understand what led you to believe that removing this fix
> was appropriate. In general, we don't add #:parallel-build? #f without
> a good reason. The code even included a comment referencing bug #28813.
> I assume that you saw the comment, since you removed it.
>
> So, what made you think that this fix was no longer needed? Can you
> help me understand how this happened?
>
> Mark
I mistakenly thought Totem had been updated since that change and I had
built it successfully a few times on my computer. I've reverted this
change on master.
signature.asc
Description: PGP signature