Re: [PATCH] Add Krita to guix

[Mark Meyer]

I tried enabling test, but sometimes it's easiest to just ask, from the
Krita IRC channel:

12:49 < ofosos> hey, I'm trying to package Krita for Guix and I'm
getting a lot 
                errors, when I activate the check phase of the build.
                Are these 
                tests supposed to pass in a release tarball? I have to
                add that 
                I set "QT_QPA_PLATFORM" "offscreen" to facilitate tests
                running 
                at all
12:50 -!- salamanderrake
address@hidden:a000:122a:32:89c6:d481:6fca:1d06] has 
          quit [Remote host closed the connection]
12:52 -!- NullConstant address@hidden has joined #krita
12:55 < scottyp_mobile> a lot of unit tests fail in general right now.
no one 
                        has had time to maintain those ofosos 
12:55 < ofosos> scottyp_mobile: is this true of the release tarballs?
then I 
                would simply disable the check phase
12:56 < scottyp_mobile> this is just true in general
12:56 < scottyp_mobile> you could try to disable them

Looks like tests won't work anyways. So the patch can't be improved in
this regard.

Cheers, Mark

On Tue, Dec 5, 2017, at 11:39, Efraim Flashner wrote:
> On Tue, Dec 05, 2017 at 11:33:22AM +0100, Mark Meyer wrote:
> > On Tue, Dec 5, 2017, at 11:30, Danny Milosavljevic wrote:
> > > Hi,
> > > 
> > > On Tue, 05 Dec 2017 02:26:15 +0100
> > > Mark Meyer <address@hidden> wrote:
> > > 
> > > > I disabled all tests, since these required an X11 display to be present.
> > > 
> > > Does (setenv "QT_QPA_PLATFORM" "offscreen") help?
> > > 
> > > If not, then it's possible to start an X server (Xvfb) in the container,
> > > something like "/bin/Xvfb :1 -screen 0 640x480x24 &".
> > 
> > 
> > Disabling the tests worked for me, and this also brings down the compile
> > time, which is already in excess of 1h on my system.
> > 
> 
> We still prefer to run all the tests as possible, or at least all the
> tests which don't require network access. Since there are no packages
> which depend on krita we have no way of testing the package without
> using it if we don't run the test suite.
> 
> -- 
> Efraim Flashner   <address@hidden>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received
> unencrypted
> Email had 1 attachment:
> + signature.asc
>   1k (application/pgp-signature)


-- 
  Mark Meyer
  address@hidden