guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 02/02: gnu: wine64-staging: Copy missing man file.


From: Ludovic Courtès
Subject: Re: 02/02: gnu: wine64-staging: Copy missing man file.
Date: Tue, 02 Jan 2018 23:25:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hi,

This is your friendly nitpicking bot!  ;-)

address@hidden (Rutger Helling) skribis:

>                                         "/bin/wine-preloader") (string-append
>                                         (assoc-ref %outputs "out")
>                                         "/bin/wine-preloader"))
> +             ;; Copy the missing man file for the wine binary from 
> wine-staging.
> +             (system (string-append "gunzip < " (string-append (assoc-ref
> +                                    %build-inputs "wine-staging")
> +                                    "/share/man/man1/wine.1.gz") "> "
> +                                    (string-append (assoc-ref %outputs "out")
> +                                    "/share/man/man1/wine.1")))
>               #t))

The indentation of the nested ‘string-append’ calls is misleading here
(and the nested calls are unnecessary because ‘string-append’ is n-ary.)

Also, I think it’s OK to leave the file compressed (we have a man page
compression phase anyway.)

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]