Re: 01/03: gnu: Add QD.

[Ludovic Courtès]

Eric Bavier <address@hidden> skribis:

> On Sat, 03 Feb 2018 22:55:56 -0500
> Mark H Weaver <address@hidden> wrote:
>
>> Hi Eric,
>> 
>> address@hidden (Eric Bavier) writes:
>> > bavier pushed a commit to branch master
>> > in repository guix.
>> >
>> > commit cbc084e1a7c25d1c8944bcb20a989f795acdb096
>> > Author: Eric Bavier <address@hidden>
>> > Date:   Wed Jan 31 13:55:37 2018 -0600
>> >
>> >     gnu: Add QD.  
>> [...]
>> > +(define-public qd
>> > +  (package
>> > +    (name "qd")
>> > +    (version "2.3.18")
>> > +    (source (origin
>> > +              (method url-fetch)
>> > +              (uri (string-append 
>> > "http://crd.lbl.gov/~dhbailey/mpdist/qd-";
>> > +                                  version ".tar.gz"))
>> > +              (sha256
>> > +               (base32
>> > +                "0vkihcj9fyv2cycq8515713gbs3yskhmivy8bznvx72i6ddnn2c1"))))
>> > +    (build-system gnu-build-system)
>> > +    (native-inputs
>> > +     `(("gfortran" ,gfortran)))
>> > +    (arguments
>> > +     `(#:configure-flags `("--disable-enable_fma" ;weird :/  
>> 
>> "weird :/" is not a very useful comment.
>
> Sorry.  I thought it was obvious it was in reference to the
> "disable-enable" bit.
>
>>  Can you change it to explain
>> why you added this flag?  It seems unfortunate to disable fused
>> multiply-add for this kind of library.
>
> The library does not support runtime ISA detection.  I thought FMAs are
> something we don't support in our baseline x86-64 builds?

Indeed.

Ludo'.