guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 03/07: gnu: libfive: Add snippet, enable tests and remove obsolete p


From: Mark H Weaver
Subject: Re: 03/07: gnu: libfive: Add snippet, enable tests and remove obsolete phase.
Date: Thu, 19 Apr 2018 08:26:22 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hi Ludovic,

address@hidden (Ludovic Courtès) writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit 0818c01aefbaa7ecce5e310ec5f70886850a7f9c
> Author: Diego Nicola Barbato <address@hidden>
> Date:   Fri Apr 6 13:43:54 2018 +0200
>
>     gnu: libfive: Add snippet, enable tests and remove obsolete phase.
>     
>     * gnu/packages/engineering.scm (libfive)[source]: Add snippet to
>     remove bundled catch.

[...]

> +                (snippet
> +                 ;; Remove bundled catch since we provide our own.
> +                 '(delete-file "libfive/test/catch.hpp"))))

It would be good to try to avoid adding more phases or snippets that
return unspecified values.  I fixed every snippet in 'core-updates', but
I guess more passes will be needed as these errors continue to be
introduced.

      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]