Re: [PATCH] core-updates: qtbase fails to compile on Linux < 3.17

[Ludovic Courtès]

Hello!

Ricardo Wurmus <address@hidden> skribis:

> qtbase sometimes fails to build on core-updates.  I now know that it
> only fails on Linux < 3.17, which is why I’ve seen the failure only on
> RHEL6 and RHEL7 systems with Linux 2.6.32 and 3.10, respectively.

Good catch!

> With the attached patch, qtbase builds on all supported kernels as the
> minimum kernel version becomes 2.6.28, which is lower than the minimum
> for glibc.
>
> It disables code that depends on the “getentropy” and “renameat2”
> syscalls.  Qtbase has a fallback implementation for random things when
> getentropy is not available.  See src/corelib/global/qrandom.cpp for
> more information.

I’m late to the party but I think it’s OK.

I think a better fix would be for Qt to handle ENOSYS correctly, which
presumably is what happens on these old kernels.  I suppose it’s also
more difficult to achieve…

Ludo’.