Re: [outreach] Help trying to create R package

[Gábor Boskovits]

Hello Laura,

Laura Lazzati <address@hidden> ezt írta (időpont: 2018.
okt. 19., P, 22:35):
>
> On Fri, Oct 19, 2018 at 3:45 PM Gábor Boskovits <address@hidden> wrote:
> >
> > Hello Laura,
> >
> > Laura Lazzati <address@hidden> ezt írta (időpont: 2018.
> > okt. 19., P, 20:37):
> > >
> > > On Fri, Oct 19, 2018 at 4:29 AM Gábor Boskovits <address@hidden> wrote:
> > > >
> > > > Hello Ricardo,
> > > >
> > > > Ricardo Wurmus <address@hidden> ezt írta (időpont: 2018. okt. 19., P 
> > > > 9:10):
> > > >>
> > > >>
> > > >> Hi Laura,
> > > >>
> > > >> > with guix environment --pure guix --ad-hoc coreutils findutils which 
> > > >> > (or -C)
> > > >> > I get, the output:
> > > >> > Command 'lesspipe' is available in the following places
> > > >> >  * /bin/lesspipe
> > > >> >  * /usr/bin/lesspipe
> > > >> > The command could not be located because '/bin:/usr/bin' is not
> > > >> > included in the PATH environment variable.
> > > >> > lesspipe: command not found
> > > >>
> > > >> This is because your shell initialization code (e.g. to set up the
> > > >> prompt) refers to lesspipe.  You can ignore this or remove the fancy
> > > >> initialization.
> > > >>
> > > >> > There, I run which guix and get:
> > > >> > which: no guix in
> > > >> > (/gnu/store/khk3lpx1li9y5zxzdppn9wi4n5g1qsgs-profile/bin:/gnu/store/khk3lpx1li9y5zxzdppn9wi4n5g1qsgs-profile/sbin)
> > > >>
> > > >> That’s because “--pure” resets the PATH; that’s by design.  The only
> > > >> problem you have is that your Guix is located elsewhere.  But why do 
> > > >> you
> > > >> need Guix itself inside of an environment to build Guix?
> > > >>
> > > >> The point of using “guix environment --pure guix” is only to enter a
> > > >> clean environment containing everything you need to build Guix from
> > > >> source.  So once you’re inside of this environment you can run the
> > > >> bootstrap and configure scripts, and run make to compile the sources.
> > > >>
> > > >> To *use* that Guix you just built you need to use “./pre-inst-env guix”
> > > >> from the source directory.
> > > >>
> > > >> > The closest I got was by setting:
> > > >> > PATH=$PATH:/usr/bin/:/bin
> > > >> > PATH=$PATH:/usr/local/bin
> > > >>
> > > >> This defeats the purpose of using “--pure” as these directories contain
> > > >> all sorts of things on a foreign distro, so you lose control over the
> > > >> environment.
> > >
> > > I am glad to tell you that I have followed all the commands, I will
> > > copy some of them here just in case, and saved the output in my daily
> > > journal of everything :)
> > >
> > > guix environment --pure guix --ad-hoc coreutils findutils which
> > > ./bootstrap
> > > ./configure --localstatedir=/var
> > > make
> > > echo $? ->got 0
> > > which guix -> got
> > > no guix in 
> > > (/gnu/store/khk3lpx1li9y5zxzdppn9wi4n5g1qsgs-profile/bin:/gnu/store/khk3lpx1li9y5zxzdppn9wi4n5g1qsgs-profile/sbin)
> > > ./pre-inst-env guix package --help -> worked fine!
> > > ./pre-inst-env guix package -i hello -> the same
> > > ./pre-inst-env guix package -i emacs
> > > export PATH="/home/laura/.guix-profile/bin${PATH:+:}$PATH"
> > > export 
> > > INFOPATH="/home/laura/.guix-profile/share/info${INFOPATH:+:}$INFOPATH"
> > > (with this two exports, I could run hello and emacs without problems)
> > > ./pre-inst-env guix package -i nss-certs
> > > Played a lot with
> > > ./pre-inst-env guix build r-aspi
> > > and
> > > emacs gnu/packages/cran.scm
> > > until I found out that there were syntax errors, mismatches in
> > > parenthesis and so on, and in the last
> > > ./pre-inst-env guix build r-aspi got:
> > > ;;; note: source file /home/laura/guix/gnu/packages/cran.scm
> > > ;;;       newer than compiled /home/laura/guix/gnu/packages/cran.go
> > > (still that) but:
> >
> > This is not a problem, it just indicates that you modified cran.scm, and it 
> > will
> > use the .scm file instead, as the .go file was compiled from an older 
> > source.
> >
> > > successfully built 
> > > /gnu/store/bmapswnk9li1nscfpirgzsy3npw9hyql-r-aspi-0.2.0.drv
> > > /gnu/store/a3apqwf4hy67ms462hn802gk89x99mzh-r-aspi-0.2.0
> > >
> >
> > That's great!
> >
> > > I am following the contribution guide now, to send the patch, I ran
> > > ./pre-inst-env guix lint r-aspi
> > > ;;; note: source file /home/laura/guix/gnu/packages/cran.scm
> > > ;;;       newer than compiled /home/laura/guix/gnu/packages/cran.go
> > > fetching CVE database for 2018...
> > > fetching CVE database for 2017...
> > > fetching CVE database for 2016...
> > > fetching CVE database for 2015...
> > >
> > > Is this output OK?
> > >
> >
> > Yes, this output is just fine.
> I have already run all the commands suggested in
> https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html#Submitting-Patches
> I have never used git format-patch before, I am reading documentation
> about it but I am not very sure about how to apply it to my package,
> could you help me in clarifying this last step?

Once you made a commit, and you are statisfied with it, then you can run:
git format-patch -1
to create a patch form the last commit.
I would store it somewhere outside the repository, so that it does not
get in your way later as an utracked file.
You can also specify the output directory directly with -o.

Once this is done, a patch file is created, with a name resembling the
commit message.
You can then do:
git send-email <patch-filename>

It will ask for the e-mail address you want to send to, you should
specify the guix-patches mailinglist.

Hope that helps.

> >
> > > >
> > > >
> > > > Sorry, my bad, I missed that.
> > > >
> > > >>
> > > >> --
> > > >> Ricardo
> > > >
> > > > g_bor
> > >
> > > Regards!
> > > Laura
> > Best regards,
> > g_bor
>
> Regards :)
> Laura
Best regards,
g_bor