Re: 01/02: gnu: rhythmbox: Update hash of patch.

[Mark H Weaver]

Hi Ludovic,

address@hidden (Ludovic Courtès) writes:

> address@hidden skribis:
>
>> commit e1d97c4efc42a661bd2772041371303e4070aa4f
>> Author: Mark H Weaver <address@hidden>
>> Date:   Mon Nov 5 04:04:45 2018 -0500
>>
>>     gnu: rhythmbox: Update hash of patch.
>>     
>>     * gnu/packages/gnome.scm (rhythmbox)[source]: Update hash of the applied
>>     patch.
>> ---
>>  gnu/packages/gnome.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 06ec28b..376cf5a 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -3746,7 +3746,7 @@ which can read a large number of file formats.")
>>                        "b182c6b9e1d09e601bac0b703cc5f8b159ebbc3a.patch"))
>>                  (sha256
>>                   (base32
>> -                  
>> "17j45vyyr071ka3nckj2gycgyyv1j08fyrxw89jfdq2442nzrsiy")))))
>> +                  
>> "06n87xgf927djmv1vshal84nqx7g8nwgljza3g2vydhy7g2n1csq")))))
>
> Could you explain the difference between the two patches?
>
> In general I think we should keep providing detailed explanations in the
> commit log (and possibly in the bug tracker) when such problems occur.

Agreed.  Thanks for paying attention to these things :)

At the time that I first committed this patch to my private branch,
Hydra was offline, and it wasn't obvious to me how to get the old
version.  However, I could see that the patch was so trivial that I
didn't worry about it.  Still, I probably should have asked on the
mailing list.

Anyway, see below for the diff between the old patch and the new one.

      Thanks,
        Mark

--8<---------------cut here---------------start------------->8---
--- t.patch     2018-11-25 16:26:38.946968736 -0500
+++ b182c6b9e1d09e601bac0b703cc5f8b159ebbc3a.patch      2018-11-25 
14:53:32.019264658 -0500
@@ -19,7 +19,7 @@
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/plugins/fmradio/rb-fm-radio-gst-src.c 
b/plugins/fmradio/rb-fm-radio-gst-src.c
-index 09d709c..88abdaf 100644
+index 09d709c28..88abdaf35 100644
 --- a/plugins/fmradio/rb-fm-radio-gst-src.c
 +++ b/plugins/fmradio/rb-fm-radio-gst-src.c
 @@ -178,7 +178,7 @@ plugin_init (GstPlugin *plugin)
@@ -31,6 +31,6 @@
                   "element to output silence",
                   plugin_init,
                   VERSION,
---
-libgit2 0.27.1
+-- 
+2.18.1
 
--8<---------------cut here---------------end--------------->8---