guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25711: Fix guile2.2-gdbm-ffi


From: Ludovic Courtès
Subject: bug#25711: Fix guile2.2-gdbm-ffi
Date: Tue, 14 Feb 2017 09:25:20 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Hi Chris!

Christopher Allan Webber <address@hidden> skribis:

> Continuing from: 
> https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00681.html
>
> Christopher Allan Webber writes:
>
>> Anyway, okay to push?  I'd love to have the buggy package not be buggy
>> in master. :)
>
> Meh, I STILL made a mistake!  I forgot to have a couple of imports
> included.  But I've tested the package and now it works.
>
> New patch attached!
>
> From 052ab44ac7eda04c11e04d03620e03872cc1e84a Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <address@hidden>
> Date: Fri, 10 Feb 2017 19:24:57 -0600
> Subject: [PATCH] guile-gdbm-ffi: Write to correct guile output directory and
>  use guild.
>
> * gnu/packages/guile.scm (guile-gdbm-ffi): Check guile for effective version
> before writing to output path.  Also fixes a bug where the guild command was
> not getting called, and instead was calling the internal guile compile-file
> procedure.  This meant that the package produced was dependent on whatever
> version of guile was powering Guix at the time.  Also set GUILE_AUTO_COMPILE
> to 0 to avoid gnarly looking warnings during build.

[...]

> +         (setenv "GUILE_AUTO_COMPILE" "0")

Maybe add a comment like “Avoid warnings” here.

Otherwise LGTM, thanks for taking care of it!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]