[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25899: [PATCH] HACKING: Describe address@hidden as the list for patc
From: |
Ricardo Wurmus |
Subject: |
bug#25899: [PATCH] HACKING: Describe address@hidden as the list for patches. |
Date: |
Tue, 28 Feb 2017 17:22:36 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.1.1 |
Marius Bakke <address@hidden> writes:
> address@hidden writes:
>
>
>> diff --git a/HACKING b/HACKING
>> index 1e0bddfaf..76568cfcb 100644
>> --- a/HACKING
>> +++ b/HACKING
>> @@ -25,8 +26,9 @@ convenient. When you deem it necessary, feel free to ask
>> for it on the
>> mailing list. When you get commit access, please make sure to follow the
>> policy below (discussions of the policy can take place on address@hidden)
>>
>> -Non-trivial patches should always be posted to address@hidden (trivial
>> -patches include fixing typos, etc.)
>> +Non-trivial patches should always be posted to address@hidden (trivial
>> +patches include fixing typos, etc.). The patches sent to this list can be
>> +tracked in its
>> [[https://debbugs.gnu.org/cgi/pkgreport.cgi?pkg=guix-patches][debbugs
>> webinterface]].
>
> I prefer using guix-devel for discussing patches and want to keep using
> it normally. I see "guix-patches" more of a "package incubator",
> especially for newcomers. For regular contributors using "guix-devel" to
> ask for feedback before pushing is fine too IMO.
In my opinion *most* patches (especially patches to add packages) ought
to be sent to “guix-patches”. “guix-devel” is for discussions of plans,
features, and more involved changes.
What’s great about “guix-patches” is that we can much more easily keep
track of the patches that are submitted in this way. With “guix-devel”
discussions it’s hard to figure out if further action is required.
@ng0: The patch looks good to me, though I’d prefer if it included
additional instructions that are specific to patch submission to a
debbugs-backed list. It’s worth noting that patches be either sent in
one direct email or as replies to a ticket acknowledgement. This
prevents flooding of the tracker.
Do you think you could add language like that? Just a sentence or two
would probably be sufficient.
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net