guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25918: [PATCH 1/3] gnu: Add libmesode.


From: Mekeor Melire
Subject: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Thu, 02 Mar 2017 23:46:26 +0100
User-agent: mu4e 0.9.18; emacs 25.1.1

Attachment: 0001-gnu-Add-libmesode.patch
Description: libmesode.patch

Attachment: 0002-gnu-Add-libstrophe.patch
Description: libstrophe.patch

Attachment: 0003-gnu-Add-profanity.patch
Description: profanity.patch


Hi Guix,
hi Ricardo.


Ricardo Wurmus <address@hidden> writes:

> This is almost ready to push, and I could make the needed changes
> myself, but maybe you’d like to handle them yourself.

Sure. :)

> Please add a “file-name” expression here to give the archive a proper
> name in the store.  We do this for all tarballs that don’t include the
> name of the package.

Done.

> Please remove the “A” from the beginning.  (I think “guix lint” also
> complains about it.)

Done. It's unfortunate that “guix lint” doesn't have a “-f” option so
that I could do “guix lint -f gnu/packages/messaging.scm” or so.

(My packaging work-flow is quite uncomfortable. I'm packaging in an my
custom GUIX_PACKAGE_PATH; and then I copy the snippets into my local
guix-repo. I wonder how your workflow looks like.)

> Please separate sentences with two spaces.

Done.

> Please add a comment that explains what this list means.

Done.

> Could you send an updated patch as a response to this email please?

Doing so.

I hope it's fine for you that I'm *attaching* the patches instead of
putting them *inline* because there are three separate patches. (I hope
the attachments reach you because I'm still unconversant with my new
mail client (mu4e).)

Was it a good idea to separate the patches, actually?


--
luv
mekeor

EDD3 DFFA 76F6 11C0 145F 9A99 AC85 BAD8 A2F8 C868

reply via email to

[Prev in Thread] Current Thread [Next in Thread]