guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26150: [PATCH 0/15]: Add pplacer and OCaml dependencies.


From: Ben Woodcroft
Subject: bug#26150: [PATCH 0/15]: Add pplacer and OCaml dependencies.
Date: Sat, 18 Mar 2017 10:36:31 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

Hi Ludo, thanks for the feedback.

On 06/03/17 19:16, Ludovic Courtès wrote:
Hi Ben,

Sorry for the delay.

Ben Woodcroft <address@hidden> skribis:

On 10/02/17 08:32, Ludovic Courtès wrote:
Hi Ben,

Ben Woodcroft <address@hidden> skribis:

I'm quite happy to send these patches in, pplacer has been near the
top of my most wanted list since I started contributing. There's two
parts that are a little out of the ordinary:

1) Unfortunately pplacer requires the outdated OCaml 4.01, so I
adapted the package-with-python2 approach.
Is there really no way upstream could update the package to current
OCaml?  That would save us a lot of packages and associated work.
I'm afraid I don't think so. I asked about this, but haven't received
a response for 3 weeks.
https://github.com/matsen/pplacer/issues/354

The recommended way of installing this software is to download
binaries, so updating the OCaml dependency may not be at the top of
the priority list. This is maintained software and there's a number of
pieces of software which rely on pplacer (including a few of my own),
so I think it is worth packaging. So, IMO we should wear the costs on
this one.
OK, that makes sense.

To make progress, how about applying the non-4.01-specific parts of the
patch series first (I think you didn’t get any feedback on these, so
it’s safe to assume they’re OK if ‘guix lint’ has nothing to say)?

Second, could you submit the bits about supporting 4.01 to guix-patches?
I’ll take a look if nobody beats me at it.
OK. I've pushed the non-4.01-specific parts to master, and attached here a modified patch series which contains the rest. There's 15 steps but most are quite trivial.

Thanks, ben.

Attachment: pplacer_v2.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]