guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26316: Enable threaded compression of source tarballs


From: Leo Famulari
Subject: bug#26316: Enable threaded compression of source tarballs
Date: Fri, 31 Mar 2017 19:04:13 -0400
User-agent: Mutt/1.8.0 (2017-02-23)

On Fri, Mar 31, 2017 at 02:15:36PM -0400, Kei Kebreau wrote:
> Leo Famulari <address@hidden> writes:
> > Subject: [PATCH] packages: Enable threaded compression of source tarballs.

> > -                                      "cvfa" #$output
> > +                                      "cvf" #$output
> > +                                      ;; The bootstrap xz does not support
> > +                                      ;; threaded compression (introduced 
> > in
> > +                                      ;; 5.2.0), but it ignores the extra 
> > flag.
> > +                                      (string-append 
> > "--use-compress-program="
> > +                                                     #+xz "/bin/xz 
> > --threads=0")

One question I have is about the removal of 'cvfa'. Here is the relevant
documentation:

-a, --auto-compress
             Use archive suffix to determine the compression
             program.

AFAICT, we only build XZ archives, so it's okay to remove 'a' and
hard-code the use of xz. Is that correct?

> >                                        ;; avoid non-determinism in the 
> > archive
> >                                        "address@hidden"
> >                                        "--owner=root:0"
> 
> LGTM.

Thanks! This does mean rebuilding the world, so we'd need to save it for
the next core-updates cycle.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]