[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado.
From: |
Christopher Baines |
Subject: |
bug#26722: [PATCH 1/3] gnu: Add python-sockjs-tornado. |
Date: |
Mon, 1 May 2017 20:25:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 01/05/17 15:46, Marius Bakke wrote:
> Hello Chris!
>
> Christopher Baines <address@hidden> writes:
>
>> * gnu/packages/python.scm (python-sockjs-tornado): New variable.
>
> [...]
>
>> +(define-public python-sockjs-tornado
>> + (package
>> + (name "python-sockjs-tornado")
>> + (version "1.0.3")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://pypi.python.org/packages/source/"
>> + "s/sockjs-tornado/sockjs-tornado-" version ".tar.gz"))
>
> Please use 'pypi-uri' here.
>
>> + (sha256
>> + (base32
>> + "16cff40nniqsyvda1pb2j3b4zwmrw7y2g1vqq78lp20xpmhnwwkd"))))
>> + (build-system python-build-system)
>> + (inputs
>> + `(("python-tornado" ,python-tornado)))
>
> Python does not have a good mechanism for specifying exact versions of
> runtime dependencies, so they should normally be propagated. If the
> package does not import this at runtime (e.g. only needed for tests) it
> should be a 'native-input'.
>
> LGTM with those changes.
Thanks for the review Marius, I've now sent some updated patches.
signature.asc
Description: OpenPGP digital signature