[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26669: [PATCH 7/7] gnu: Add dvdstyler.
From: |
Ludovic Courtès |
Subject: |
bug#26669: [PATCH 7/7] gnu: Add dvdstyler. |
Date: |
Wed, 03 May 2017 15:04:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Thomas Danckaert <address@hidden> skribis:
> From: Thomas Danckaert <address@hidden>
>
> * gnu/packages/cdrom.scm (dvdstyler): New variable.
[...]
> + (arguments
> + `(#:configure-flags (list (string-append "XMLTO="
> + (assoc-ref %build-inputs
> "xmlto")
> + "/bin/xmlto"
> + " --searchpath "
> + (assoc-ref %build-inputs
> "docbook-xsl")
> +
> "/xml/xsl/docbook-xsl-1.79.1/htmlhelp:"
> + (assoc-ref %build-inputs
> "docbook-xml")
> + "/xml/dtd/docbook"))
I'd expect that adding libxml2 as an input would lead to the appropriate
definition of XML_CATALOG_FILES, and thus remove the need for these
#:configure-flags. Could you try that?
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'wrap-program
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (wrap-program (string-append (assoc-ref outputs "out")
> "/bin/dvdstyler")
> + `("PATH" ":" prefix
> + (,(string-join
> + (map (lambda (in) (string-append (assoc-ref inputs in)
> "/bin"))
> + '("cdrtools" "dvdauthor" "dvd+rw-tools"
> "ffmpeg"))
<-------'
Identation. :-)
> + ":")))))))
Please return #t at the end of the phase.
> + (license gpl2)))
GPLv2-only, right?
Otherwise LGTM, thanks!
Ludo’.
- bug#26669: [PATCH 7/7] gnu: Add dvdstyler.,
Ludovic Courtès <=