guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26875: [v2] system: grub: Expose GRUB's interactive interface settin


From: Leo Famulari
Subject: bug#26875: [v2] system: grub: Expose GRUB's interactive interface settings.
Date: Sat, 13 May 2017 12:40:32 -0400
User-agent: Mutt/1.8.2 (2017-04-18)

On Sat, May 13, 2017 at 03:51:27PM +0200, Ludovic Courtès wrote:
> > address@hidden @code{terminal-outputs} (default: @code{'gfxterm})
> > +The output terminals used for the GRUB boot menu, as a list of symbols.
> > +These values are accepted: console, serial, address@hidden@}, gfxterm,
> > +vga_text, mda_text, morse, spkmodem
> 
> Please use @code for the possible, add a final period, and a
> cross-reference to the relevant part of the GRUB manual with
> “(@pxref{…})” if possible.

Okay!

> 
> > address@hidden @code{terminal-inputs} (default: @code{'()})
> > +The input terminals used for the GRUB boot menu, as a list of symbols.
> > +The default is the native platform terminal as determined by GRUB at
> > +run-time.  These values are accepted: console, serial, address@hidden@},
> > +at_keyboard, usb_keyboard.
> > +
> > address@hidden @code{serial-unit} (default: @code{#f})
> > +The serial unit used by GRUB, as an integer from 0 to 3.  The default
> > +value is chosen by GRUB at run-time; currently GRUB chooses 0, which
> > +corresponds to COM1.
> 
> Likewise.

Yes!

> 
> > address@hidden @code{serial-speed} (default: @code{#f})
> > +The speed of the serial interface, as an integer.  The default value is
> > +chosen by GRUB at run-time; currently GRUB chooses 9600bps.
> 
> 9,address@hidden  :-)

Sure!

> Apart from that, as long as “make check-system TESTS=basic” and similar
> pass, that’s all good for me!

I tried the basic, btrfs-root-os, and encrypted-root-os tests. Testers
should note this is an ABI break.

> Mathieu: is it OK to apply this before the patch series on non-GRUB
> bootloaders?

I'll wait for this response.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]