guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27075: [PATCH] gnu: Add multitail


From: Marius Bakke
Subject: bug#27075: [PATCH] gnu: Add multitail
Date: Thu, 25 May 2017 23:13:52 +0200
User-agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu)

Stefan Reichör <address@hidden> writes:

> Hi there,
>
> I am not sure what category fits best for multitail. I have added it to
> less as a first attempt.

Thanks for this! I think "logging.scm" works well for this package. A
few comments:

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-curses-lib
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* "mt.h"
> +                 (("ncursesw\\/panel.h") "panel.h")
> +                 (("ncursesw\\/ncurses.h") "ncurses.h")))
> +             #t))
> +         (delete 'configure)
> +         (delete 'check)))) ; no test suite (make check just runs cppcheck)

Instead of deleting the 'check' phase, you can set the #:tests? keyword
to #f.

> +    (inputs `(("ncurses" ,ncurses)))
> +    (home-page "https://vanheusden.com/multitail/";)
> +    (synopsis "Monitor multiple logfiles")
> +    (description
> +     "MultiTail allows you to monitor logfiles and command output in multiple
> +windows in a terminal, colorize, filter and merge.")
> +    (license gpl2)))

When there is no version information indicated in the source code
headers, we default to "or later" (i.e. gpl2+ in this instance).

The rest LGTM. Can you send an updated patch?

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]