guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26941: New font-build-system


From: Ludovic Courtès
Subject: bug#26941: New font-build-system
Date: Sun, 28 May 2017 14:38:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Arun Isaac <address@hidden> skribis:

>>> A side issue: I feel that the `install-file' procedure should print out
>>> what it's doing to stdout (or some log port). Something like:
>>>
>>> (format #t "~a -> ~a~%" source destination)
>>>
>>> This would save us the trouble of implementing this log printing
>>> everywhere `install-file' is called. For example, this could be very
>>> useful in the 'install' phase of the font-build-sytem. WDYT?
>>
>> Do we really need to print something in the first place?  :-)  Some
>> procedures in (guix build utils) do that, indeed, but I’m not sure it’s
>> useful for something as simple as ‘install-file’.  Thoughts?
>
> Yes, I think it is really important. Without the verbose output, one
> will have to stare at a blank screen, guessing at what is
> happening. Long verbose output feels reassuring that something is going
> on. :-) Also, verbose output for `install-file' might help in debugging
> correct source/destination paths.

OK.  I’m not entirely convinced, because I think that either the build
completes and it’s easy to check that the files are where you wanted
them to be, or it fails, and you get an exception.  I’m not strongly
opposed either, so perhaps something to consider in the next
‘core-updates’ cycle.

>>> +                   ,@(let ((compression (resolve-module '(gnu packages 
>>> compression))))
>>> +                       (map (match-lambda
>>> +                              ((name package)
>>> +                               (list name (module-ref compression 
>>> package))))
>>> +                            `(("tar" tar)
>>> +                              ("gzip" gzip)
>>> +                              ("bzip2" bzip2)
>>> +                              ("xz" xz))))))
>>
>> This works, but since ‘tar’ is defined in (gnu packages base), it’s
>> better to take it from there.
>
> Done! I have also included "unzip" because several font packages come as
> zip archives. WDYT?

Makes sense!

> From a0bda2fc48c6d2c7809805251154c49e8be76d67 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <address@hidden>
> Date: Mon, 15 May 2017 20:08:57 +0530
> Subject: [PATCH 1/5] build-system: Add 'font-build-system'.
>
> * Makefile.am (MODULES): Add 'guix/build-system/font.scm' and
>   'guix/build/font-build-system.scm'.
> * guix/build-system/font.scm: New file.
> * guix/build/font-build-system.scm: New file.
> * doc/guix.texi (Build Systems): Add 'font-build-system'.

Alright, OK for this and the following patches.

Thank you!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]